Re: [PATCH v8 2/2] json-writer: t0019: add perl unit test

[Jeff Hostetler]

On 6/7/2018 1:13 PM, Eric Sunshine wrote:

On Thu, Jun 7, 2018 at 10:12 AM,   wrote:

Test json-writer output using perl script.

Signed-off-by: Jeff Hostetler 
---
diff --git a/t/t0019/parse_json.perl b/t/t0019/parse_json.perl
@@ -0,0 +1,52 @@
+#!/usr/bin/perl
+use strict;
+use warnings;
+use JSON;


This new script is going to have to be protected by a prerequisite
since the JSON module is not part of the standard Perl installation,
thus will not necessarily be installed everywhere (it isn't on any of
my machines, for instance). Something like:

 test_lazy_prereq PERLJSON '
 perl -MJSON -e "exit 0"
 '

which would be used like this:

 test_expect_success PERLJSON 'parse JSON using Perl' '
 ...
 '



will do.  thanks!
Jeff

Re: [PATCH v8 2/2] json-writer: t0019: add perl unit test

[Eric Sunshine]

On Thu, Jun 7, 2018 at 10:12 AM,   wrote:
> Test json-writer output using perl script.
>
> Signed-off-by: Jeff Hostetler 
> ---
> diff --git a/t/t0019/parse_json.perl b/t/t0019/parse_json.perl
> @@ -0,0 +1,52 @@
> +#!/usr/bin/perl
> +use strict;
> +use warnings;
> +use JSON;

This new script is going to have to be protected by a prerequisite
since the JSON module is not part of the standard Perl installation,
thus will not necessarily be installed everywhere (it isn't on any of
my machines, for instance). Something like:

test_lazy_prereq PERLJSON '
perl -MJSON -e "exit 0"
'

which would be used like this:

test_expect_success PERLJSON 'parse JSON using Perl' '
...
'

[PATCH v8 2/2] json-writer: t0019: add perl unit test

[git]

From: Jeff Hostetler 

Test json-writer output using perl script.

Signed-off-by: Jeff Hostetler 
---
 t/t0019-json-writer.sh  | 38 
 t/t0019/parse_json.perl | 52 +
 2 files changed, 90 insertions(+)
 create mode 100644 t/t0019/parse_json.perl

diff --git a/t/t0019-json-writer.sh b/t/t0019-json-writer.sh
index c9c2e23..fd61fe4 100755
--- a/t/t0019-json-writer.sh
+++ b/t/t0019-json-writer.sh
@@ -233,4 +233,42 @@ test_expect_success 'inline array with no members' '
test_cmp expect actual
 '
 
+# As a sanity check, ask Perl to parse our generated JSON and recursively
+# dump the resulting data in sorted order.  Confirm that that matches our
+# expectations.
+test_expect_success 'parse JSON using Perl' '
+   cat >expect <<-\EOF &&
+   row[0].a abc
+   row[0].b 42
+   row[0].sub1 hash
+   row[0].sub1.c 3.14
+   row[0].sub1.d 1
+   row[0].sub1.sub2 array
+   row[0].sub1.sub2[0] 0
+   row[0].sub1.sub2[1] hash
+   row[0].sub1.sub2[1].g 0
+   row[0].sub1.sub2[1].h 1
+   row[0].sub1.sub2[2] null
+   EOF
+   test-json-writer >output.json \
+   @object \
+   @object-string a abc \
+   @object-int b 42 \
+   @object-object "sub1" \
+   @object-double c 2 3.140 \
+   @object-true d \
+   @object-array "sub2" \
+   @array-false \
+   @array-object \
+   @object-int g 0 \
+   @object-int h 1 \
+   @end \
+   @array-null \
+   @end \
+   @end \
+   @end &&
+   perl "$TEST_DIRECTORY"/t0019/parse_json.perl actual &&
+   test_cmp expect actual
+'
+
 test_done
diff --git a/t/t0019/parse_json.perl b/t/t0019/parse_json.perl
new file mode 100644
index 000..ca4e5bf
--- /dev/null
+++ b/t/t0019/parse_json.perl
@@ -0,0 +1,52 @@
+#!/usr/bin/perl
+use strict;
+use warnings;
+use JSON;
+
+sub dump_array {
+my ($label_in, $ary_ref) = @_;
+my @ary = @$ary_ref;
+
+for ( my $i = 0; $i <= $#{ $ary_ref }; $i++ )
+{
+   my $label = "$label_in\[$i\]";
+   dump_item($label, $ary[$i]);
+}
+}
+
+sub dump_hash {
+my ($label_in, $obj_ref) = @_;
+my %obj = %$obj_ref;
+
+foreach my $k (sort keys %obj) {
+   my $label = (length($label_in) > 0) ? "$label_in.$k" : "$k";
+   my $value = $obj{$k};
+
+   dump_item($label, $value);
+}
+}
+
+sub dump_item {
+my ($label_in, $value) = @_;
+if (ref($value) eq 'ARRAY') {
+   print "$label_in array\n";
+   dump_array($label_in, $value);
+} elsif (ref($value) eq 'HASH') {
+   print "$label_in hash\n";
+   dump_hash($label_in, $value);
+} elsif (defined $value) {
+   print "$label_in $value\n";
+} else {
+   print "$label_in null\n";
+}
+}
+
+my $row = 0;
+while (<>) {
+my $data = decode_json( $_ );
+my $label = "row[$row]";
+
+dump_hash($label, $data);
+$row++;
+}
+
-- 
2.9.3