Re: [PATCH v9 1/5] t4041, t4205, t6006, t7102: use iso8859-1 rather than iso-8859-1
Alexey Shumkin alex.crez...@gmail.com writes: This is actually a fixup of de6029a2d7734a93a9e27b9c4471862a47dd8123, which was applied before final patch series was sent. Also, see 3994e8a98dc7bbf67e61d23c8125f44383499a1f for the explanation of such a replacement. These are not very useful in a log message. People who read the history 6 months down the road would want to see why we want to use iso8859-1 not iso-8859-1 explained. Both iso8859-1 and iso-8859-1 are understood as latin-1 by modern platforms, but the latter is not understood by older platforms;update tests to use the former. This is in line with 3994e8a9 (t4201: use ISO8859-1 rather than ISO-8859-1, 2009-12-03), which did the same. Signed-off-by: Alexey Shumkin alex.crez...@gmail.com Reviewed-by: Johannes Sixt j.s...@viscovery.net I do not recall this exact patch reviewed by J6t, but perhaps I missed a message on the list? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9 1/5] t4041, t4205, t6006, t7102: use iso8859-1 rather than iso-8859-1
On Thu, Jul 04, 2013 at 11:47:04PM -0700, Junio C Hamano wrote: Alexey Shumkin alex.crez...@gmail.com writes: This is actually a fixup of de6029a2d7734a93a9e27b9c4471862a47dd8123, which was applied before final patch series was sent. Also, see 3994e8a98dc7bbf67e61d23c8125f44383499a1f for the explanation of such a replacement. These are not very useful in a log message. People who read the history 6 months down the road would want to see why we want to use iso8859-1 not iso-8859-1 explained. Both iso8859-1 and iso-8859-1 are understood as latin-1 by modern platforms, but the latter is not understood by older platforms;update tests to use the former. This is in line with 3994e8a9 (t4201: use ISO8859-1 rather than ISO-8859-1, 2009-12-03), which did the same. Yep, it whould be better, I thought to do like this but I didn't ) Signed-off-by: Alexey Shumkin alex.crez...@gmail.com Reviewed-by: Johannes Sixt j.s...@viscovery.net I do not recall this exact patch reviewed by J6t, but perhaps I missed a message on the list? I've reread 'SubmittingPatches' doc, and I can say I used Reviewed-by incorrectly. Sorry for this. It must be Suggested-by there, I guess. -- Alexey Shumkin -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9 1/5] t4041, t4205, t6006, t7102: use iso8859-1 rather than iso-8859-1
Alexey Shumkin alex.crez...@gmail.com writes: Both iso8859-1 and iso-8859-1 are understood as latin-1 by modern platforms, but the latter is not understood by older platforms;update tests to use the former. This is in line with 3994e8a9 (t4201: use ISO8859-1 rather than ISO-8859-1, 2009-12-03), which did the same. Yep, it whould be better, I thought to do like this but I didn't ) Signed-off-by: Alexey Shumkin alex.crez...@gmail.com Reviewed-by: Johannes Sixt j.s...@viscovery.net I do not recall this exact patch reviewed by J6t, but perhaps I missed a message on the list? I've reread 'SubmittingPatches' doc, and I can say I used Reviewed-by incorrectly. Sorry for this. It must be Suggested-by there, I guess. OK, then I'll queue this patch (but not 2-4/5 yet) with log message amended. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9 1/5] t4041, t4205, t6006, t7102: use iso8859-1 rather than iso-8859-1
On Fri, Jul 05, 2013 at 01:11:49AM -0700, Junio C Hamano wrote: Alexey Shumkin alex.crez...@gmail.com writes: Both iso8859-1 and iso-8859-1 are understood as latin-1 by modern platforms, but the latter is not understood by older platforms;update tests to use the former. This is in line with 3994e8a9 (t4201: use ISO8859-1 rather than ISO-8859-1, 2009-12-03), which did the same. Yep, it whould be better, I thought to do like this but I didn't ) Signed-off-by: Alexey Shumkin alex.crez...@gmail.com Reviewed-by: Johannes Sixt j.s...@viscovery.net I do not recall this exact patch reviewed by J6t, but perhaps I missed a message on the list? I've reread 'SubmittingPatches' doc, and I can say I used Reviewed-by incorrectly. Sorry for this. It must be Suggested-by there, I guess. OK, then I'll queue this patch (but not 2-4/5 yet) with log message amended. Excuse me, you've said Ok for 2/5 message, and then explained (as I understood) then subtle difference between EOF and \EOF. Should I change the message somehow? Thanks. -- Alexey Shumkin -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9 1/5] t4041, t4205, t6006, t7102: use iso8859-1 rather than iso-8859-1
Alexey Shumkin alex.crez...@gmail.com writes: OK, then I'll queue this patch (but not 2-4/5 yet) with log message amended. Excuse me, you've said Ok for 2/5 message, and then explained (as I understood) then subtle difference between EOF and \EOF. Should I change the message somehow? I left it up to you. If I queued without waiting, it wouldn't have been up-to-you, so... -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v9 1/5] t4041, t4205, t6006, t7102: use iso8859-1 rather than iso-8859-1
This is actually a fixup of de6029a2d7734a93a9e27b9c4471862a47dd8123,
which was applied before final patch series was sent.
Also, see 3994e8a98dc7bbf67e61d23c8125f44383499a1f for the explanation
of such a replacement.
Signed-off-by: Alexey Shumkin alex.crez...@gmail.com
Reviewed-by: Johannes Sixt j.s...@viscovery.net
---
t/t4041-diff-submodule-option.sh | 4 ++--
t/t4205-log-pretty-formats.sh| 8
t/t6006-rev-list-format.sh | 14 +++---
t/t7102-reset.sh | 10 +-
4 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/t/t4041-diff-submodule-option.sh b/t/t4041-diff-submodule-option.sh
index 0a4f496..1751c83 100755
--- a/t/t4041-diff-submodule-option.sh
+++ b/t/t4041-diff-submodule-option.sh
@@ -23,8 +23,8 @@ add_file () {
echo $name $name
git add $name
test_tick
- msg_added_iso88591=$(echo Add $name ($added $name) |
iconv -f utf-8 -t iso-8859-1)
- git -c 'i18n.commitEncoding=iso-8859-1' commit -m
$msg_added_iso88591
+ msg_added_iso88591=$(echo Add $name ($added $name) |
iconv -f utf-8 -t iso8859-1)
+ git -c 'i18n.commitEncoding=iso8859-1' commit -m
$msg_added_iso88591
done /dev/null
git rev-parse --short --verify HEAD
)
diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh
index 3cfb744..c283842 100755
--- a/t/t4205-log-pretty-formats.sh
+++ b/t/t4205-log-pretty-formats.sh
@@ -32,8 +32,8 @@ test_expect_success 'set up basic repos' '
bar
git add foo
test_tick
- git config i18n.commitEncoding iso-8859-1
- git commit -m $(commit_msg iso-8859-1)
+ git config i18n.commitEncoding iso8859-1
+ git commit -m $(commit_msg iso8859-1)
git add bar
test_tick
git commit -m add bar
@@ -61,8 +61,8 @@ test_expect_success 'alias user-defined format' '
test_cmp expected actual
'
-test_expect_success 'alias user-defined tformat with %s (iso-8859-1 encoding)'
'
- git config i18n.logOutputEncoding iso-8859-1
+test_expect_success 'alias user-defined tformat with %s (iso8859-1 encoding)' '
+ git config i18n.logOutputEncoding iso8859-1
git log --oneline expected-s
git log --pretty=tformat:%h %s actual-s
git config --unset i18n.logOutputEncoding
diff --git a/t/t6006-rev-list-format.sh b/t/t6006-rev-list-format.sh
index 380c85b..4751d22 100755
--- a/t/t6006-rev-list-format.sh
+++ b/t/t6006-rev-list-format.sh
@@ -12,15 +12,15 @@ test_tick
# String added in German (translated with Google Translate), encoded in
UTF-8,
# used as a commit log message below.
added=$(printf added (hinzugef\303\274gt) foo)
-added_iso88591=$(echo $added | iconv -f utf-8 -t iso-8859-1)
+added_iso88591=$(echo $added | iconv -f utf-8 -t iso8859-1)
# same but changed
changed=$(printf changed (ge\303\244ndert) foo)
-changed_iso88591=$(echo $changed | iconv -f utf-8 -t iso-8859-1)
+changed_iso88591=$(echo $changed | iconv -f utf-8 -t iso8859-1)
test_expect_success 'setup' '
: foo
git add foo
- git config i18n.commitEncoding iso-8859-1
+ git config i18n.commitEncoding iso8859-1
git commit -m $added_iso88591
head1=$(git rev-parse --verify HEAD)
head1_short=$(git rev-parse --verify --short $head1)
@@ -136,9 +136,9 @@ EOF
test_format encoding %e EOF
commit $head2
-iso-8859-1
+iso8859-1
commit $head1
-iso-8859-1
+iso8859-1
EOF
test_format subject %s EOF
@@ -242,9 +242,9 @@ test_format complex-encoding %e EOF
commit $head3
iso8859-1
commit $head2
-iso-8859-1
+iso8859-1
commit $head1
-iso-8859-1
+iso8859-1
EOF
test_format complex-subject %s EOF
diff --git a/t/t7102-reset.sh b/t/t7102-reset.sh
index 9132dd9..2ef96e9 100755
--- a/t/t7102-reset.sh
+++ b/t/t7102-reset.sh
@@ -39,7 +39,7 @@ test_expect_success 'creating initial files and commits' '
echo 1st line 2nd file secondfile
echo 2nd line 2nd file secondfile
- git -c i18n.commitEncoding=iso-8859-1 commit -a -m $(commit_msg
iso-8859-1)
+ git -c i18n.commitEncoding=iso8859-1 commit -a -m $(commit_msg
iso8859-1)
head5=$(git rev-parse --verify HEAD)
'
# git log --pretty=oneline # to see those SHA1 involved
@@ -62,10 +62,10 @@ test_expect_success 'reset --hard message' '
test_cmp .expected .actual
'
-test_expect_success 'reset --hard message (iso-8859-1 logoutencoding)' '
+test_expect_success 'reset --hard message (iso8859-1 logoutputencoding)' '
hex=$(git log -1 --format=%h)
- git -c i18n.logOutputEncoding=iso-8859-1 reset --hard .actual
- echo HEAD is now at $hex $(commit_msg iso-8859-1) .expected
+ git -c i18n.logOutputEncoding=iso8859-1 reset --hard .actual
+ echo HEAD is now at $hex $(commit_msg iso8859-1) .expected
