Re: [PATCHv4 2/2] Documentation/clone: document ignored configuration variables

[Jonathan Nieder]

Hi,

SZEDER Gábor wrote:

> Due to limitations/bugs in the current implementation, some
> configuration variables specified via 'git clone -c var=val' (or 'git
> -c var=val clone') are ignored during the initial fetch and checkout.
>
> Let the users know which configuration variables are known to be
> ignored ('remote.origin.mirror' and 'remote.origin.tagOpt') under the
> documentation of 'git clone -c'.
>
> Signed-off-by: SZEDER Gábor 
> ---
>  Documentation/git-clone.txt | 4 
>  1 file changed, 4 insertions(+)

Makes sense.

> diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt
> index ec41d3d69..4f1e7d4ba 100644
> --- a/Documentation/git-clone.txt
> +++ b/Documentation/git-clone.txt
> @@ -186,6 +186,10 @@ objects from the source repository into a pack in the 
> cloned repository.
>   values are given for the same key, each value will be written to
>   the config file. This makes it safe, for example, to add
>   additional fetch refspecs to the origin remote.
> + Note that due to limitations of the current implementation some
> + configuration variables don't take effect during the initial
> + fetch and checkout.  Configuration variables known to not take
> + effect are: `remote..mirror` and `remote..tagOpt`.
>  

Tiny nit: the paragraph of --config description is already a bit
overwhelming, and I think this additional note takes it over the edge
where I give up and stop reading.  Could it go in a separate
paragraph?

the config file. This makes it safe, for example, to add
additional fetch refspecs to the origin remote.
+
Due to limitations in the current implementation, some
configuration variables do not take effect until after the
initial fetch and checkout. Configuration variables known
not to take effect are `remote..mirror` and
`remote..tagOpt`.

Thanks,
Jonathan

Re: [PATCHv4 2/2] Documentation/clone: document ignored configuration variables

[Ævar Arnfjörð Bjarmason]

On Wed, May 31, 2017 at 10:50 AM, SZEDER Gábor  wrote:
> On Tue, May 30, 2017 at 11:01 AM, Ævar Arnfjörð Bjarmason
>  wrote:
>> On Tue, May 30, 2017 at 9:12 AM, SZEDER Gábor  wrote:
>
>>> diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt
>>> index ec41d3d69..4f1e7d4ba 100644
>>> --- a/Documentation/git-clone.txt
>>> +++ b/Documentation/git-clone.txt
>>> @@ -186,6 +186,10 @@ objects from the source repository into a pack in the 
>>> cloned repository.
>>> values are given for the same key, each value will be written to
>>> the config file. This makes it safe, for example, to add
>>> additional fetch refspecs to the origin remote.
>>> +   Note that due to limitations of the current implementation some
>>> +   configuration variables don't take effect during the initial
>>> +   fetch and checkout.  Configuration variables known to not take
>>> +   effect are: `remote..mirror` and `remote..tagOpt`.
>>
>> We should add to that: "Instead supply the --mirror and --no-tags
>> options, respectively".
>
> I don't think we can do that in this patch right now.  This topic
> branches off from c3808ca69 (preparing for 2.10.3, 2016-12-05), I
> assume because, as a bugfix, it will be included in maintenance
> releases for older releases, and those won't have the '--no-tags'
> option.  Perhaps as a follow-up, only on master.

Sorry, my misunderstanding. I didn't think we'd be updating docs like
this in maint releases, thought this was for to-be-2.14.

Re: [PATCHv4 2/2] Documentation/clone: document ignored configuration variables

[SZEDER Gábor]

On Tue, May 30, 2017 at 11:01 AM, Ævar Arnfjörð Bjarmason
 wrote:
> On Tue, May 30, 2017 at 9:12 AM, SZEDER Gábor  wrote:

>> diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt
>> index ec41d3d69..4f1e7d4ba 100644
>> --- a/Documentation/git-clone.txt
>> +++ b/Documentation/git-clone.txt
>> @@ -186,6 +186,10 @@ objects from the source repository into a pack in the 
>> cloned repository.
>> values are given for the same key, each value will be written to
>> the config file. This makes it safe, for example, to add
>> additional fetch refspecs to the origin remote.
>> +   Note that due to limitations of the current implementation some
>> +   configuration variables don't take effect during the initial
>> +   fetch and checkout.  Configuration variables known to not take
>> +   effect are: `remote..mirror` and `remote..tagOpt`.
>
> We should add to that: "Instead supply the --mirror and --no-tags
> options, respectively".

I don't think we can do that in this patch right now.  This topic
branches off from c3808ca69 (preparing for 2.10.3, 2016-12-05), I
assume because, as a bugfix, it will be included in maintenance
releases for older releases, and those won't have the '--no-tags'
option.  Perhaps as a follow-up, only on master.

Re: [PATCHv4 2/2] Documentation/clone: document ignored configuration variables

[Ævar Arnfjörð Bjarmason]

On Tue, May 30, 2017 at 9:12 AM, SZEDER Gábor  wrote:
> Due to limitations/bugs in the current implementation, some
> configuration variables specified via 'git clone -c var=val' (or 'git
> -c var=val clone') are ignored during the initial fetch and checkout.
>
> Let the users know which configuration variables are known to be
> ignored ('remote.origin.mirror' and 'remote.origin.tagOpt') under the
> documentation of 'git clone -c'.
>
> Signed-off-by: SZEDER Gábor 
> ---
>  Documentation/git-clone.txt | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt
> index ec41d3d69..4f1e7d4ba 100644
> --- a/Documentation/git-clone.txt
> +++ b/Documentation/git-clone.txt
> @@ -186,6 +186,10 @@ objects from the source repository into a pack in the 
> cloned repository.
> values are given for the same key, each value will be written to
> the config file. This makes it safe, for example, to add
> additional fetch refspecs to the origin remote.
> +   Note that due to limitations of the current implementation some
> +   configuration variables don't take effect during the initial
> +   fetch and checkout.  Configuration variables known to not take
> +   effect are: `remote..mirror` and `remote..tagOpt`.

We should add to that: "Instead supply the --mirror and --no-tags
options, respectively".

>  --depth ::
> Create a 'shallow' clone with a history truncated to the
> --
> 2.13.0.35.g14b6294b1
>

[PATCHv4 2/2] Documentation/clone: document ignored configuration variables

[SZEDER Gábor]

Due to limitations/bugs in the current implementation, some
configuration variables specified via 'git clone -c var=val' (or 'git
-c var=val clone') are ignored during the initial fetch and checkout.

Let the users know which configuration variables are known to be
ignored ('remote.origin.mirror' and 'remote.origin.tagOpt') under the
documentation of 'git clone -c'.

Signed-off-by: SZEDER Gábor 
---
 Documentation/git-clone.txt | 4 
 1 file changed, 4 insertions(+)

diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt
index ec41d3d69..4f1e7d4ba 100644
--- a/Documentation/git-clone.txt
+++ b/Documentation/git-clone.txt
@@ -186,6 +186,10 @@ objects from the source repository into a pack in the 
cloned repository.
values are given for the same key, each value will be written to
the config file. This makes it safe, for example, to add
additional fetch refspecs to the origin remote.
+   Note that due to limitations of the current implementation some
+   configuration variables don't take effect during the initial
+   fetch and checkout.  Configuration variables known to not take
+   effect are: `remote..mirror` and `remote..tagOpt`.
 
 --depth ::
Create a 'shallow' clone with a history truncated to the
-- 
2.13.0.35.g14b6294b1