On Tue, Jun 12, 2018 at 11:10 PM Todd Zullinger wrote:
>
> This replaces my 2/2 "use in-tree Git.pm for tests" with
> Luis's improved version. It also adds Luis's fix to ensure
> the proper exit status on test failures and a minor
> whitespace cleanup.
>
> Is it alright to forge your signoff Luis?
Thanks, that's fine.
You should sign-off on those, too: you identified the problems, told
me the solutions, tested them, and deserve the credit.
Moreover, Documentation/SubmittingPatches encourages it.
When the patches are ready, I think we'll need the primary author
(Ted) to acknowledge before the maintainer (Junio) can approve.
> Luis Marsano (2):
> git-credential-netrc: use in-tree Git.pm for tests
> git-credential-netrc: fix exit status when tests fail
>
> Todd Zullinger (2):
> git-credential-netrc: make "all" default target of Makefile
> git-credential-netrc: minor whitespace cleanup in test script
>
> contrib/credential/netrc/Makefile | 3 +++
> contrib/credential/netrc/t-git-credential-netrc.sh | 9 +
> contrib/credential/netrc/test.pl | 5 +++--
> 3 files changed, 11 insertions(+), 6 deletions(-)
