Re: [RFC PATCH v2 2/4] git-credential-netrc: minor whitespace cleanup in test script
On Wed, Jun 13, 2018 at 1:21 PM Todd Zullinger wrote: > Eric Sunshine wrote: > > Since you're touching all the tests in this script anyhow, perhaps > > modernize them [...] > > (Not necessarily worth a re-roll.) > > These tests were based on similar test_external tests which > use perl. like t0202 & t9700. Both examples use the same > formatting (and use of 'set up'). Perhaps a later clean up > can adjust all three tests? Whichever course of action works for you and Junio is fine. In this case, it's such a minor bit of additional work to modernize the two tests in this script that it would make sense to do so in this patch if you happen to re-roll (and if you agree with me), but is itself probably not worth a re-roll (as mentioned above).
Re: [RFC PATCH v2 2/4] git-credential-netrc: minor whitespace cleanup in test script
Eric Sunshine wrote: > On Tue, Jun 12, 2018 at 11:10 PM, Todd Zullinger wrote: >> Signed-off-by: Todd Zullinger >> --- >> diff --git a/contrib/credential/netrc/t-git-credential-netrc.sh >> b/contrib/credential/netrc/t-git-credential-netrc.sh >> index 58191a62f8..c5661087fe 100755 >> --- a/contrib/credential/netrc/t-git-credential-netrc.sh >> +++ b/contrib/credential/netrc/t-git-credential-netrc.sh >> @@ -17,15 +17,15 @@ >> # set up test repository >> >> test_expect_success \ >> -'set up test repository' \ >> -'git config --add gpg.program test.git-config-gpg' >> + 'set up test repository' \ >> + 'git config --add gpg.program test.git-config-gpg' > > Since you're touching all the tests in this script anyhow, perhaps > modernize them so the title and opening quote of the test body are on > the same line as test_expect_success, and the closing body quote is on > a line of its own? > > test_expect_sucess 'setup test repository' ' > ...test body... > ' > > I also changed "set up" to "setup" to follow existing practice. > > (Not necessarily worth a re-roll.) These tests were based on similar test_external tests which use perl. like t0202 & t9700. Both examples use the same formatting (and use of 'set up'). Perhaps a later clean up can adjust all three tests? -- Todd ~~ How can I tell that the past isn't a fiction designed to account for the discrepancy between my immediate physical sensation and my state of mind? -- Douglas Adams
Re: [RFC PATCH v2 2/4] git-credential-netrc: minor whitespace cleanup in test script
On Tue, Jun 12, 2018 at 11:10 PM, Todd Zullinger wrote: > Signed-off-by: Todd Zullinger > --- > diff --git a/contrib/credential/netrc/t-git-credential-netrc.sh > b/contrib/credential/netrc/t-git-credential-netrc.sh > index 58191a62f8..c5661087fe 100755 > --- a/contrib/credential/netrc/t-git-credential-netrc.sh > +++ b/contrib/credential/netrc/t-git-credential-netrc.sh > @@ -17,15 +17,15 @@ > # set up test repository > > test_expect_success \ > -'set up test repository' \ > -'git config --add gpg.program test.git-config-gpg' > + 'set up test repository' \ > + 'git config --add gpg.program test.git-config-gpg' Since you're touching all the tests in this script anyhow, perhaps modernize them so the title and opening quote of the test body are on the same line as test_expect_success, and the closing body quote is on a line of its own? test_expect_sucess 'setup test repository' ' ...test body... ' I also changed "set up" to "setup" to follow existing practice. (Not necessarily worth a re-roll.) > # The external test will outputs its own plan > test_external_has_tap=1 > > test_external \ > -'git-credential-netrc' \ > -perl "$TEST_DIRECTORY"/../contrib/credential/netrc/test.pl > + 'git-credential-netrc' \ > + perl "$TEST_DIRECTORY"/../contrib/credential/netrc/test.pl > > test_done > )
[RFC PATCH v2 2/4] git-credential-netrc: minor whitespace cleanup in test script
Signed-off-by: Todd Zullinger --- contrib/credential/netrc/t-git-credential-netrc.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/credential/netrc/t-git-credential-netrc.sh b/contrib/credential/netrc/t-git-credential-netrc.sh index 58191a62f8..c5661087fe 100755 --- a/contrib/credential/netrc/t-git-credential-netrc.sh +++ b/contrib/credential/netrc/t-git-credential-netrc.sh @@ -17,15 +17,15 @@ # set up test repository test_expect_success \ -'set up test repository' \ -'git config --add gpg.program test.git-config-gpg' + 'set up test repository' \ + 'git config --add gpg.program test.git-config-gpg' # The external test will outputs its own plan test_external_has_tap=1 test_external \ -'git-credential-netrc' \ -perl "$TEST_DIRECTORY"/../contrib/credential/netrc/test.pl + 'git-credential-netrc' \ + perl "$TEST_DIRECTORY"/../contrib/credential/netrc/test.pl test_done )