Re: [msysGit] Re: [PATCH 4/6] t4210: skip command-line encoding tests on mingw

2014-07-21 Thread Johannes Schindelin 
Hi Junio,

On Mon, 21 Jul 2014, Junio C Hamano wrote:

 Oh by the way, can somebody remind me why we spell these as
 NOT_MINGW,  instead of !MINGW?

I guess that is my mistake; when I introduced the use of NOT_MINGW I was
simply unaware of the !MINGW syntax.

Let's use the latter consistently?

Ciao,
Johannes
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [msysGit] Re: [PATCH 4/6] t4210: skip command-line encoding tests on mingw

2014-07-21 Thread Johannes Sixt 
Am 21.07.2014 19:45, schrieb Johannes Schindelin:
 Hi Junio,
 
 On Mon, 21 Jul 2014, Junio C Hamano wrote:
 
 Oh by the way, can somebody remind me why we spell these as
 NOT_MINGW,  instead of !MINGW?
 
 I guess that is my mistake; when I introduced the use of NOT_MINGW I was
 simply unaware of the !MINGW syntax.

You can hardly be blamed. The first occurrence of NOT_MINGW was added
much earlier than the ability to negate prerequisite tokens.

 Let's use the latter consistently?

Of course!

-- Hannes

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html