RE: [PATCH v6 2/8] read-cache: teach make_cache_entry to take object_id

2018-07-05 Thread Jameson Miller
> >
> > Teach make_cache_entry function to take object_id instead of a SHA-1.
> 
> This repeats the subject line?
> 
> Sign off missing.

Thank you Stefan for pointing this out. This does not add much information to 
the subject line. I could clean it up if I re-roll to fix up the missing sign 
off.

Junio - would you like me to re-roll this patch series and include the correct 
sign off, or would you be able to correct this? I can do whichever is easiest 
for you.


Re: [PATCH v6 2/8] read-cache: teach make_cache_entry to take object_id

2018-07-02 Thread Stefan Beller
On Mon, Jul 2, 2018 at 12:49 PM Jameson Miller  wrote:
>
> Teach make_cache_entry function to take object_id instead of a SHA-1.

This repeats the subject line?

Sign off missing.