RE: [PATCH v7 06/12] ls-files: Add support in ls-files to display the fsmonitor valid bit
> -Original Message- > From: David Turner [mailto:david.tur...@twosigma.com] > Sent: Tuesday, September 19, 2017 5:27 PM > To: 'Ben Peart' ; Ben Peart > > Cc: ava...@gmail.com; christian.cou...@gmail.com; git@vger.kernel.org; > gits...@pobox.com; johannes.schinde...@gmx.de; pclo...@gmail.com; > p...@peff.net > Subject: RE: [PATCH v7 06/12] ls-files: Add support in ls-files to display the > fsmonitor valid bit > > > > -Original Message- > > From: Ben Peart [mailto:peart...@gmail.com] > > Sent: Tuesday, September 19, 2017 4:45 PM > > To: David Turner ; 'Ben Peart' > > > > Cc: ava...@gmail.com; christian.cou...@gmail.com; git@vger.kernel.org; > > gits...@pobox.com; johannes.schinde...@gmx.de; pclo...@gmail.com; > > p...@peff.net > > Subject: Re: [PATCH v7 06/12] ls-files: Add support in ls-files to > > display the fsmonitor valid bit > > > > > > > > On 9/19/2017 3:46 PM, David Turner wrote: > > >> -Original Message- > > >> From: Ben Peart [mailto:benpe...@microsoft.com] > > >> Sent: Tuesday, September 19, 2017 3:28 PM > > >> To: benpe...@microsoft.com > > >> Cc: David Turner ; ava...@gmail.com; > > >> christian.cou...@gmail.com; git@vger.kernel.org; gits...@pobox.com; > > >> johannes.schinde...@gmx.de; pclo...@gmail.com; p...@peff.net > > >> Subject: [PATCH v7 06/12] ls-files: Add support in ls-files to > > >> display the fsmonitor valid bit > > >> > > >> Add a new command line option (-f) to ls-files to have it use > > >> lowercase letters for 'fsmonitor valid' files > > >> > > >> Signed-off-by: Ben Peart > > >> --- > > >> builtin/ls-files.c | 8 ++-- > > >> 1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > This is still missing the corresponding documentation patch. > > > > Sorry for the confusion. > > Thanks for following up. > > > > 10/12 (no reply, haven't checked whether same issue but I assume > > > same issue since the new case I mentioned isn't added) > > > > It wasn't a bug so I didn't "fix" it. I just sent an explanation and > > patch demonstrating why. You can find it here: > > I was concerned about the case of an untracked file inside a directory that > contains no tracked files. Your patch in this mail treats dir3 just like > dir1 and > dir2. I think you ought to test the case of a dir with no tracked files. > In the case where there is an untracked file inside a directory that contains no tracked files, git will (as shown by the "failing" test) actually find the untracked file. This is the correct/expected behavior. The test failure is just indicating that the optimization of not searching that directory for untracked files was not able to occur (because there was no entry in the untracked cache for that directory). > After more careful checking, it looks like this case does work, but it's still > worth testing.
RE: [PATCH v7 06/12] ls-files: Add support in ls-files to display the fsmonitor valid bit
> -Original Message- > From: Ben Peart [mailto:peart...@gmail.com] > Sent: Tuesday, September 19, 2017 4:45 PM > To: David Turner ; 'Ben Peart' > > Cc: ava...@gmail.com; christian.cou...@gmail.com; git@vger.kernel.org; > gits...@pobox.com; johannes.schinde...@gmx.de; pclo...@gmail.com; > p...@peff.net > Subject: Re: [PATCH v7 06/12] ls-files: Add support in ls-files to display the > fsmonitor valid bit > > > > On 9/19/2017 3:46 PM, David Turner wrote: > >> -Original Message- > >> From: Ben Peart [mailto:benpe...@microsoft.com] > >> Sent: Tuesday, September 19, 2017 3:28 PM > >> To: benpe...@microsoft.com > >> Cc: David Turner ; ava...@gmail.com; > >> christian.cou...@gmail.com; git@vger.kernel.org; gits...@pobox.com; > >> johannes.schinde...@gmx.de; pclo...@gmail.com; p...@peff.net > >> Subject: [PATCH v7 06/12] ls-files: Add support in ls-files to > >> display the fsmonitor valid bit > >> > >> Add a new command line option (-f) to ls-files to have it use > >> lowercase letters for 'fsmonitor valid' files > >> > >> Signed-off-by: Ben Peart > >> --- > >> builtin/ls-files.c | 8 ++-- > >> 1 file changed, 6 insertions(+), 2 deletions(-) > > > > This is still missing the corresponding documentation patch. > > Sorry for the confusion. Thanks for following up. > > 10/12 (no reply, haven't checked whether same issue but I assume same > > issue since the new case I mentioned isn't added) > > It wasn't a bug so I didn't "fix" it. I just sent an explanation and patch > demonstrating why. You can find it here: I was concerned about the case of an untracked file inside a directory that contains no tracked files. Your patch in this mail treats dir3 just like dir1 and dir2. I think you ought to test the case of a dir with no tracked files. After more careful checking, it looks like this case does work, but it's still worth testing.
Re: [PATCH v7 06/12] ls-files: Add support in ls-files to display the fsmonitor valid bit
On 9/19/2017 3:46 PM, David Turner wrote: -Original Message- From: Ben Peart [mailto:benpe...@microsoft.com] Sent: Tuesday, September 19, 2017 3:28 PM To: benpe...@microsoft.com Cc: David Turner ; ava...@gmail.com; christian.cou...@gmail.com; git@vger.kernel.org; gits...@pobox.com; johannes.schinde...@gmx.de; pclo...@gmail.com; p...@peff.net Subject: [PATCH v7 06/12] ls-files: Add support in ls-files to display the fsmonitor valid bit Add a new command line option (-f) to ls-files to have it use lowercase letters for 'fsmonitor valid' files Signed-off-by: Ben Peart --- builtin/ls-files.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) This is still missing the corresponding documentation patch. Sorry for the confusion. The documentation is all in a patch together as they all have links to each other. You can find it here: https://public-inbox.org/git/20170919192744.19224-6-benpe...@microsoft.com/T/#u I can see from replies that at least some of my messages got through. In total, I sent messages about: 04/12 (I see replies) 05/12 (I see replies) 06/12 (no reply, issue not fixed) The documentation is all in a patch together as they all have links to each other. You can find it here: https://public-inbox.org/git/20170919192744.19224-6-benpe...@microsoft.com/T/#u 10/12 (no reply, haven't checked whether same issue but I assume same issue since the new case I mentioned isn't added) It wasn't a bug so I didn't "fix" it. I just sent an explanation and patch demonstrating why. You can find it here: https://public-inbox.org/git/84981984-02c1-f322-a617-57dfe1d87...@gmail.com/T/#u 12/12 (no reply, typo fixed -- no reply required) Hope this helps.
RE: [PATCH v7 06/12] ls-files: Add support in ls-files to display the fsmonitor valid bit
> -Original Message- > From: Ben Peart [mailto:benpe...@microsoft.com] > Sent: Tuesday, September 19, 2017 3:28 PM > To: benpe...@microsoft.com > Cc: David Turner ; ava...@gmail.com; > christian.cou...@gmail.com; git@vger.kernel.org; gits...@pobox.com; > johannes.schinde...@gmx.de; pclo...@gmail.com; p...@peff.net > Subject: [PATCH v7 06/12] ls-files: Add support in ls-files to display the > fsmonitor valid bit > > Add a new command line option (-f) to ls-files to have it use lowercase > letters for 'fsmonitor valid' files > > Signed-off-by: Ben Peart > --- > builtin/ls-files.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) This is still missing the corresponding documentation patch. I can see from replies that at least some of my messages got through. In total, I sent messages about: 04/12 (I see replies) 05/12 (I see replies) 06/12 (no reply, issue not fixed) 10/12 (no reply, haven't checked whether same issue but I assume same issue since the new case I mentioned isn't added) 12/12 (no reply, typo fixed -- no reply required)
