Re: What's cooking in git.git (Sep 2017, #02; Mon, 11)

[Johannes Schindelin]

Hi Junio,

On Mon, 11 Sep 2017, Junio C Hamano wrote:

> * js/rebase-i-final (2017-07-27) 10 commits
>  - rebase -i: rearrange fixup/squash lines using the rebase--helper
>  - t3415: test fixup with wrapped oneline
>  - rebase -i: skip unnecessary picks using the rebase--helper
>  - rebase -i: check for missing commits in the rebase--helper
>  - t3404: relax rebase.missingCommitsCheck tests
>  - rebase -i: also expand/collapse the SHA-1s via the rebase--helper
>  - rebase -i: do not invent onelines when expanding/collapsing SHA-1s
>  - rebase -i: remove useless indentation
>  - rebase -i: generate the script via rebase--helper
>  - t3415: verify that an empty instructionFormat is handled as before
> 
>  The final batch to "git rebase -i" updates to move more code from
>  the shell script to C.
> 
>  Expecting a reroll.

No you don't: xmqqfudqkcux@gitster.mtv.corp.google.com

> [...]
> 
> --
> [Cooking]
> 
> [...]
> 
> * mk/diff-delta-uint-may-be-shorter-than-ulong (2017-08-10) 1 commit
>  . diff-delta: fix encoding size that would not fit in "unsigned int"
> 
>  The machinery to create xdelta used in pack files received the
>  sizes of the data in size_t, but lost the higher bits of them by
>  storing them in "unsigned int" during the computation, which is
>  fixed.
> 
>  Dropped, as it was rerolled for review as part of a larger series.
>  cf. <1502914591-26215-1-git-send-email-martin@mail.zuhause>
> 
> [...]
> 
> * mk/use-size-t-in-zlib (2017-08-10) 1 commit
>  . zlib.c: use size_t for size
> 
>  The wrapper to call into zlib followed our long tradition to use
>  "unsigned long" for sizes of regions in memory, which have been
>  updated to use "size_t".
> 
>  Dropped, as it was rerolled for review as part of a larger series.
>  cf. <1502914591-26215-1-git-send-email-martin@mail.zuhause>
> 
> 
> * mk/diff-delta-avoid-large-offset (2017-08-11) 1 commit
>  . diff-delta: do not allow delta offset truncation
> 
>  The delta format used in the packfile cannot reference data at
>  offset larger than what can be expressed in 4-byte, but the
>  generator for the data failed to make sure the offset does not
>  overflow.  This has been corrected.
> 
>  Dropped, as it was rerolled for review as part of a larger series.
>  cf. <1502914591-26215-1-git-send-email-martin@mail.zuhause>
> 
> [...]
> 
> --
> [Discarded]
> 
> [...]

This section would be more appropriate for the three "Dropped" patch
series than the "Cooking" section.

Ciao,
Dscho

Re: What's cooking in git.git (Sep 2017, #02; Mon, 11)

[Junio C Hamano]

Thomas Gummerer  writes:

> On 09/11, Kevin Willford wrote:
>> > 
>> > * kw/write-index-reduce-alloc (2017-09-08) 2 commits
>> >  - read-cache: fix index corruption with index v4
>> >  - Add t/helper/test-write-cache to .gitignore
>> > 
>> >  Expecting a reroll.
>> >  cf. > > q...@mail.gmail.com>
>> > 
>> I didn't submit these patches so what would you like
>> me to do?

Nothing ;-).  

These two are fixups to a recent topic; the name of the topic branch
does not mean fixes and updates must come only from those who share
the initial 'kw'.

>> The reroll for read-cache fix was submitted here
>> https://public-inbox.org/git/20170907192412.8085-1-t.gumme...@gmail.com/
>
> I noticed that it has already been picked up as well, as
> 0b90b881e0c1de110c724fe63df6d2c3c9680d6a.  Maybe it's just the What's
> cooking that needs to be updated, or is there something else missing?

Yeah, thanks for keeping an eye on what's on 'pu'.

Re: What's cooking in git.git (Sep 2017, #02; Mon, 11)

[Thomas Gummerer]

On 09/11, Kevin Willford wrote:
> > 
> > * kw/write-index-reduce-alloc (2017-09-08) 2 commits
> >  - read-cache: fix index corruption with index v4
> >  - Add t/helper/test-write-cache to .gitignore
> > 
> >  Expecting a reroll.
> >  cf.  > q...@mail.gmail.com>
> > 
> I didn't submit these patches so what would you like
> me to do?
> 
> The reroll for read-cache fix was submitted here
> https://public-inbox.org/git/20170907192412.8085-1-t.gumme...@gmail.com/

I noticed that it has already been picked up as well, as
0b90b881e0c1de110c724fe63df6d2c3c9680d6a.  Maybe it's just the What's
cooking that needs to be updated, or is there something else missing?

> - Kevin
> 

RE: What's cooking in git.git (Sep 2017, #02; Mon, 11)

[Kevin Willford]

> 
> * kw/write-index-reduce-alloc (2017-09-08) 2 commits
>  - read-cache: fix index corruption with index v4
>  - Add t/helper/test-write-cache to .gitignore
> 
>  Expecting a reroll.
>  cf.  q...@mail.gmail.com>
> 
I didn't submit these patches so what would you like
me to do?

The reroll for read-cache fix was submitted here
https://public-inbox.org/git/20170907192412.8085-1-t.gumme...@gmail.com/

- Kevin