Re: [PATCH] Fix detection of uname failure
Hi Charles, On 2015-07-17 14:11, Charles Bailey wrote: diff --git a/dir.c b/dir.c index 8209f8b..52dbfd0 100644 --- a/dir.c +++ b/dir.c @@ -1848,7 +1848,7 @@ static const char *get_ident_string(void) if (sb.len) return sb.buf; - if (uname(uts)) + if (uname(uts) == -1) From a quick `git grep '== -1'` and another quick `git grep ' 0'` it appears to me that we prefer the latter. Maybe you want to adjust it in the patch, too? Ciao, Johannes -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix detection of uname failure
On Fri, Jul 17, 2015 at 03:06:57PM +0200, Johannes Schindelin wrote: From a quick `git grep '== -1'` and another quick `git grep ' 0'` it appears to me that we prefer the latter. Maybe you want to adjust it in the patch, too? I did the same grep and found lots of examples of both. Many of the 0 applied to comparisons with variables and not API calls and many were internal (to git) calls and not POSIX or C library calls so I wasn't convinced to change my initial fix. Having said that and thought about it some more, I think ' 0' is probably better. In POSIX, we shouldn't ever get a negative value which isn't -1, but if we ever do it is probably safer to fail. I'll send and update. Charles. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix detection of uname failure
Charles Bailey char...@hashpling.org writes: ... I think ' 0' is probably better. In POSIX, we shouldn't ever get a negative value which isn't -1, but if we ever do it is probably safer to fail. I'll send and update. Thanks; I was about to type the same reasoning and conclusion ;-) -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
