Re: [PATCH] t7510: do not fail when gpg warns about insecure memory
Kyle J. McKay venit, vidit, dixit 09.03.2015 06:32: On Mar 8, 2015, at 18:22, brian m. carlson wrote: On Sun, Mar 08, 2015 at 06:15:55PM -0400, Eric Sunshine wrote: On Sun, Mar 8, 2015 at 6:04 PM, brian m. carlson sand...@crustytoothpaste.net wrote: Perhaps this is better? Unfortunately when running the test, that message is found in the standard output of git show -s --show-signature, but in the standard error of git verify-commit -v causing the comparisons of both standard output and standard error to fail. That doesn't help me parse it any better. It's the but without a corresponding not which seems to be throwing me off. Typically, one would write this but not that or not this but that. I can't tell if there is a not missing or if the but is supposed to be an and or if something else was intended. The intended meaning is and with the additional sense of contrast. The sentence, if read with verbal emphasis, is, …is found in the standard *output* of git show -s --signature, but in the standard *error* of git verify-commit -v, thus demonstrating why the test fails: the pairs of output files don't match up. Maybe you can suggest a less confusing wording. I like Brian's wording, but how about this slight variation, does this parse any better for you? Unfortunately when running the test, while that message is found in the standard output of git show -s --show-signature, it is found in the standard error of git verify-commit -v causing the comparisons of both standard output and standard error to fail. -Kyle That still makes it sound as if we'd rather fix git show than adjust the test to such surprising behavior. But in fact, git verify-commit uses stdout and stderr to separate its output appropriately, whereas git show lumps everything together on stdout, so that the test has to split it up again. Now, if I read it correctly, the patch suggests ignoring the insecure memory warning from both outputs rather than putting it on the correct side of the split. I'd rather put it on the correct side (or silence gpg by setting its config). Michael -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] t7510: do not fail when gpg warns about insecure memory
On Sun, Mar 8, 2015 at 11:40 AM, Kyle J. McKay mack...@gmail.com wrote: Depending on how gpg was built, it may issue the following message to stderr when run: Warning: using insecure memory! Unfortunately when running the test, that message gets collected in the stdout result of git show -s --show-signature but is collected in the stderr result of git verify-commit -v I'm having trouble parsing this. Is there a word missing? causing both the stdout and stderr result comparisions to fail. s/comparisions/comparisons/ Since checking for secure memory use by gpg is not the point of this test, filter out such messages to allow the test to pass even when gpg is using insecure memory. Signed-off-by: Kyle J. McKay mack...@gmail.com -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] t7510: do not fail when gpg warns about insecure memory
On Sun, Mar 8, 2015 at 6:04 PM, brian m. carlson sand...@crustytoothpaste.net wrote: On Sun, Mar 08, 2015 at 05:43:41PM -0400, Eric Sunshine wrote: On Sun, Mar 8, 2015 at 11:40 AM, Kyle J. McKay mack...@gmail.com wrote: Warning: using insecure memory! Unfortunately when running the test, that message gets collected in the stdout result of git show -s --show-signature but is collected in the stderr result of git verify-commit -v I'm having trouble parsing this. Is there a word missing? Perhaps this is better? Unfortunately when running the test, that message is found in the standard output of git show -s --show-signature, but in the standard error of git verify-commit -v causing the comparisons of both standard output and standard error to fail. That doesn't help me parse it any better. It's the but without a corresponding not which seems to be throwing me off. Typically, one would write this but not that or not this but that. I can't tell if there is a not missing or if the but is supposed to be an and or if something else was intended. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] t7510: do not fail when gpg warns about insecure memory
On Sun, Mar 08, 2015 at 06:15:55PM -0400, Eric Sunshine wrote: On Sun, Mar 8, 2015 at 6:04 PM, brian m. carlson sand...@crustytoothpaste.net wrote: Perhaps this is better? Unfortunately when running the test, that message is found in the standard output of git show -s --show-signature, but in the standard error of git verify-commit -v causing the comparisons of both standard output and standard error to fail. That doesn't help me parse it any better. It's the but without a corresponding not which seems to be throwing me off. Typically, one would write this but not that or not this but that. I can't tell if there is a not missing or if the but is supposed to be an and or if something else was intended. The intended meaning is and with the additional sense of contrast. The sentence, if read with verbal emphasis, is, …is found in the standard *output* of git show -s --signature, but in the standard *error* of git verify-commit -v, thus demonstrating why the test fails: the pairs of output files don't match up. Maybe you can suggest a less confusing wording. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187 signature.asc Description: Digital signature
Re: [PATCH] t7510: do not fail when gpg warns about insecure memory
On Mar 8, 2015, at 18:22, brian m. carlson wrote: On Sun, Mar 08, 2015 at 06:15:55PM -0400, Eric Sunshine wrote: On Sun, Mar 8, 2015 at 6:04 PM, brian m. carlson sand...@crustytoothpaste.net wrote: Perhaps this is better? Unfortunately when running the test, that message is found in the standard output of git show -s --show-signature, but in the standard error of git verify-commit -v causing the comparisons of both standard output and standard error to fail. That doesn't help me parse it any better. It's the but without a corresponding not which seems to be throwing me off. Typically, one would write this but not that or not this but that. I can't tell if there is a not missing or if the but is supposed to be an and or if something else was intended. The intended meaning is and with the additional sense of contrast. The sentence, if read with verbal emphasis, is, …is found in the standard *output* of git show -s --signature, but in the standard *error* of git verify-commit -v, thus demonstrating why the test fails: the pairs of output files don't match up. Maybe you can suggest a less confusing wording. I like Brian's wording, but how about this slight variation, does this parse any better for you? Unfortunately when running the test, while that message is found in the standard output of git show -s --show-signature, it is found in the standard error of git verify-commit -v causing the comparisons of both standard output and standard error to fail. -Kyle -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] t7510: do not fail when gpg warns about insecure memory
On Sun, Mar 08, 2015 at 05:43:41PM -0400, Eric Sunshine wrote: On Sun, Mar 8, 2015 at 11:40 AM, Kyle J. McKay mack...@gmail.com wrote: Depending on how gpg was built, it may issue the following message to stderr when run: Warning: using insecure memory! Unfortunately when running the test, that message gets collected in the stdout result of git show -s --show-signature but is collected in the stderr result of git verify-commit -v I'm having trouble parsing this. Is there a word missing? causing both the stdout and stderr result comparisions to fail. Perhaps this is better? Unfortunately when running the test, that message is found in the standard output of git show -s --show-signature, but in the standard error of git verify-commit -v causing the comparisons of both standard output and standard error to fail. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187 signature.asc Description: Digital signature
