Re: [PATCH 1/1] Fix typo in merge-strategies documentation

2018-03-22 Thread Junio C Hamano
Johannes Schindelin  writes:

> On Mon, 19 Mar 2018, Junio C Hamano wrote:
>
>> David Pursehouse  writes:
>> 
>> > From: David Pursehouse 
>> >
>> > Signed-off-by: David Pursehouse 
>> > ---
>> 
>> I somehow had to stare at the patch for a few minutes, view it in
>> two Emacs buffers and run M-x compare-windows before I finally spot
>> the single-byte typofix.
>
> Pro-tip: git am && git show --color-words

Yeah, I know, but that would not work while I am wondering if the
patch is worth applying in the first place ;-)


Re: [PATCH 1/1] Fix typo in merge-strategies documentation

2018-03-21 Thread David Pursehouse
On Tue, Mar 20, 2018 at 1:51 AM, Junio C Hamano  wrote:
>
> I somehow had to stare at the patch for a few minutes, view it in
> two Emacs buffers and run M-x compare-windows before I finally spot
> the single-byte typofix.
>
> Will queue with a retitle.

[resending as plain text]

Thanks, and sorry for the confusion.  I'll provide a more detailed
commit message next time.


Re: [PATCH 1/1] Fix typo in merge-strategies documentation

2018-03-21 Thread Johannes Schindelin
Hi Junio,

On Mon, 19 Mar 2018, Junio C Hamano wrote:

> David Pursehouse  writes:
> 
> > From: David Pursehouse 
> >
> > Signed-off-by: David Pursehouse 
> > ---
> 
> I somehow had to stare at the patch for a few minutes, view it in
> two Emacs buffers and run M-x compare-windows before I finally spot
> the single-byte typofix.

Pro-tip: git am && git show --color-words

:-)

Ciao,
Dscho


Re: [PATCH 1/1] Fix typo in merge-strategies documentation

2018-03-19 Thread Junio C Hamano
David Pursehouse  writes:

> From: David Pursehouse 
>
> Signed-off-by: David Pursehouse 
> ---

I somehow had to stare at the patch for a few minutes, view it in
two Emacs buffers and run M-x compare-windows before I finally spot
the single-byte typofix.

Will queue with a retitle.

Documentation/merge-strategies: typofix

It's strategy, not stragegy.

Signed-off-by: David Pursehouse 
Signed-off-by: Junio C Hamano 

Thanks.


>  Documentation/merge-strategies.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/merge-strategies.txt 
> b/Documentation/merge-strategies.txt
> index fd5d748d1..4a58aad4b 100644
> --- a/Documentation/merge-strategies.txt
> +++ b/Documentation/merge-strategies.txt
> @@ -40,7 +40,7 @@ the other tree did, declaring 'our' history contains all 
> that happened in it.
>  
>  theirs;;
>   This is the opposite of 'ours'; note that, unlike 'ours', there is
> - no 'theirs' merge stragegy to confuse this merge option with.
> + no 'theirs' merge strategy to confuse this merge option with.
>  
>  patience;;
>   With this option, 'merge-recursive' spends a little extra time


Re: [PATCH 1/1] Fix typo in merge-strategies documentation

2018-03-19 Thread Johannes Schindelin
Hi David,

On Sat, 17 Mar 2018, David Pursehouse wrote:

> diff --git a/Documentation/merge-strategies.txt 
> b/Documentation/merge-strategies.txt
> index fd5d748d1..4a58aad4b 100644
> --- a/Documentation/merge-strategies.txt
> +++ b/Documentation/merge-strategies.txt
> @@ -40,7 +40,7 @@ the other tree did, declaring 'our' history contains all 
> that happened in it.
>  
>  theirs;;
>   This is the opposite of 'ours'; note that, unlike 'ours', there is
> - no 'theirs' merge stragegy to confuse this merge option with.
> + no 'theirs' merge strategy to confuse this merge option with.

Well spotted: it is `strategy`, not `stragegy` (nor `stragedy`, I might
want to add :-))

I just verified that there is no other hit in `git grep stragegy`'s
output.

Thanks,
Johannes