Re: [PATCH 1/5] gc: remove unused #include "sigchain.h"
Tobias Klauserwrites: > On 2015-10-22 at 22:14:29 +0200, Junio C Hamano wrote: >> Tobias Klauser writes: >> >> > After switching to use the tempfile module in commit ebebeaea (gc: use >> > tempfile module to handle gc.pid file), no declarations from sigchain.h >> > are used in builtin/gc.c anymore. Thus, remove the #include. >> > >> > Signed-off-by: Tobias Klauser >> > --- >> >> I'll drop this one as we seem to have gained another user of the API >> in this file in the nd/gc-auto-background-fix topic. > > Opps, sorry I didn't check against 'pu' carefully enough. Thanks for > catching it. Heh, that topic has been in master since Oct 15, I think. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/5] gc: remove unused #include "sigchain.h"
On 2015-10-22 at 22:14:29 +0200, Junio C Hamanowrote: > Tobias Klauser writes: > > > After switching to use the tempfile module in commit ebebeaea (gc: use > > tempfile module to handle gc.pid file), no declarations from sigchain.h > > are used in builtin/gc.c anymore. Thus, remove the #include. > > > > Signed-off-by: Tobias Klauser > > --- > > I'll drop this one as we seem to have gained another user of the API > in this file in the nd/gc-auto-background-fix topic. Opps, sorry I didn't check against 'pu' carefully enough. Thanks for catching it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/5] gc: remove unused #include "sigchain.h"
Tobias Klauserwrites: > After switching to use the tempfile module in commit ebebeaea (gc: use > tempfile module to handle gc.pid file), no declarations from sigchain.h > are used in builtin/gc.c anymore. Thus, remove the #include. > > Signed-off-by: Tobias Klauser > --- I'll drop this one as we seem to have gained another user of the API in this file in the nd/gc-auto-background-fix topic. > builtin/gc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/builtin/gc.c b/builtin/gc.c > index 9ff0204..dc8a242 100644 > --- a/builtin/gc.c > +++ b/builtin/gc.c > @@ -15,7 +15,6 @@ > #include "lockfile.h" > #include "parse-options.h" > #include "run-command.h" > -#include "sigchain.h" > #include "argv-array.h" > #include "commit.h" -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html