Re: [PATCH 4/4] t5002: check if unzip supports symlinks
René Scharfe wrote: Am 07.01.2013 09:52, schrieb Jonathan Nieder: Hm. Do some implementations of unzip not support symlinks, or is the problem that some systems build Info-ZIP without the SYMLINKS option? The unzip supplied with NetBSD 6.0.1, which is based on libarchive, doesn't support symlinks. It creates a file with the link target path as its only content for such entries. Ok, that makes sense. A quick search finds https://code.google.com/p/libarchive/issues/detail?id=104, which if I understand correctly was fixed in libarchive 3.0.2. NetBSD 6 uses a patched 2.8.4. [...] For the test script there is no difference: If we don't have a tool to verify symlinks in archives, we better skip that part. Yeah, I just wanted to see if there were other parts of the world that needed fixing while at it. Thanks for explaining. Ciao, Jonathan -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/4] t5002: check if unzip supports symlinks
René Scharfe wrote: Only add a symlink to the repository if both the filesystem and unzip support symlinks. To check the latter, add a ZIP file containing a symlink, created like this with InfoZIP zip 3.0: $ echo sample text textfile $ ln -s textfile symlink $ zip -y infozip-symlinks.zip textfile symlink Hm. Do some implementations of unzip not support symlinks, or is the problem that some systems build Info-ZIP without the SYMLINKS option? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/4] t5002: check if unzip supports symlinks
Am 07.01.2013 09:52, schrieb Jonathan Nieder: René Scharfe wrote: Only add a symlink to the repository if both the filesystem and unzip support symlinks. To check the latter, add a ZIP file containing a symlink, created like this with InfoZIP zip 3.0: $ echo sample text textfile $ ln -s textfile symlink $ zip -y infozip-symlinks.zip textfile symlink Hm. Do some implementations of unzip not support symlinks, or is the problem that some systems build Info-ZIP without the SYMLINKS option? The unzip supplied with NetBSD 6.0.1, which is based on libarchive, doesn't support symlinks. It creates a file with the link target path as its only content for such entries. I assume that Info-ZIP is compiled with the SYMLINKS option on all platforms whose default filesystem supports symbolic links. Except on Windows perhaps, where it's complicated. For the test script there is no difference: If we don't have a tool to verify symlinks in archives, we better skip that part. René -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
