Re: [PATCH v13 11/12] tag.c: implement '--format' option
On Mon, Aug 24, 2015 at 8:44 PM, Matthieu Moy wrote: > Karthik Nayak writes: > >> On Mon, Aug 24, 2015 at 1:26 AM, Matthieu Moy >> wrote: >>> Karthik Nayak writes: >>> --- a/Documentation/git-tag.txt +++ b/Documentation/git-tag.txt @@ -13,7 +13,8 @@ SYNOPSIS [ | ] 'git tag' -d ... 'git tag' [-n[]] -l [--contains ] [--points-at ] - [--column[=] | --no-column] [--create-reflog] [--sort=] [...] + [--column[=] | --no-column] [--create-reflog] [--sort=] + [--format=] [...] 'git tag' -v ... DESCRIPTION @@ -158,6 +159,11 @@ This option is only applicable when listing tags without annotation lines. The object that the new tag will refer to, usually a commit. Defaults to HEAD. +:: >>> >>> Shouldn't this be --format , not just ? We usually use >>> the named argument in the SYNOPSIS for positional arguments, but not for >>> arguments following an option. >> >> This is how it was in for-each-ref Documentation, hence to keep it similar I >> just put . > > "It's wrong in another place" sounds like an argument to fix the other > place, not to get it wrong here too ;-). > Of course! That was just me justifying my action. I agree, it should be corrected both places. -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v13 11/12] tag.c: implement '--format' option
Karthik Nayak writes: > On Mon, Aug 24, 2015 at 1:26 AM, Matthieu Moy > wrote: >> Karthik Nayak writes: >> >>> --- a/Documentation/git-tag.txt >>> +++ b/Documentation/git-tag.txt >>> @@ -13,7 +13,8 @@ SYNOPSIS >>>[ | ] >>> 'git tag' -d ... >>> 'git tag' [-n[]] -l [--contains ] [--points-at ] >>> - [--column[=] | --no-column] [--create-reflog] [--sort=] >>> [...] >>> + [--column[=] | --no-column] [--create-reflog] [--sort=] >>> + [--format=] [...] >>> 'git tag' -v ... >>> >>> DESCRIPTION >>> @@ -158,6 +159,11 @@ This option is only applicable when listing tags >>> without annotation lines. >>> The object that the new tag will refer to, usually a commit. >>> Defaults to HEAD. >>> >>> +:: >> >> Shouldn't this be --format , not just ? We usually use >> the named argument in the SYNOPSIS for positional arguments, but not for >> arguments following an option. > > This is how it was in for-each-ref Documentation, hence to keep it similar I > just put . "It's wrong in another place" sounds like an argument to fix the other place, not to get it wrong here too ;-). -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v13 11/12] tag.c: implement '--format' option
On Mon, Aug 24, 2015 at 1:26 AM, Matthieu Moy wrote: > Karthik Nayak writes: > >> --- a/Documentation/git-tag.txt >> +++ b/Documentation/git-tag.txt >> @@ -13,7 +13,8 @@ SYNOPSIS >>[ | ] >> 'git tag' -d ... >> 'git tag' [-n[]] -l [--contains ] [--points-at ] >> - [--column[=] | --no-column] [--create-reflog] [--sort=] >> [...] >> + [--column[=] | --no-column] [--create-reflog] [--sort=] >> + [--format=] [...] >> 'git tag' -v ... >> >> DESCRIPTION >> @@ -158,6 +159,11 @@ This option is only applicable when listing tags >> without annotation lines. >> The object that the new tag will refer to, usually a commit. >> Defaults to HEAD. >> >> +:: > > Shouldn't this be --format , not just ? We usually use > the named argument in the SYNOPSIS for positional arguments, but not for > arguments following an option. > This is how it was in for-each-ref Documentation, hence to keep it similar I just put . -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v13 11/12] tag.c: implement '--format' option
Karthik Nayak writes: > --- a/Documentation/git-tag.txt > +++ b/Documentation/git-tag.txt > @@ -13,7 +13,8 @@ SYNOPSIS >[ | ] > 'git tag' -d ... > 'git tag' [-n[]] -l [--contains ] [--points-at ] > - [--column[=] | --no-column] [--create-reflog] [--sort=] > [...] > + [--column[=] | --no-column] [--create-reflog] [--sort=] > + [--format=] [...] > 'git tag' -v ... > > DESCRIPTION > @@ -158,6 +159,11 @@ This option is only applicable when listing tags without > annotation lines. > The object that the new tag will refer to, usually a commit. > Defaults to HEAD. > > +:: Shouldn't this be --format , not just ? We usually use the named argument in the SYNOPSIS for positional arguments, but not for arguments following an option. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
