Re: [PATCH v2] commit: add commit.signoff config option
Junio C Hamano writes: > [commit] > signoff = "I certify that all my work is licenseable under DCO" I like this one. The paranoid version would be signoff = "I certify that all my work in /home/my/projects/foo are ..." to avoid mistakenly have the config option applied to the wrong repo. But that's probably overkill. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] commit: add commit.signoff config option
On 2015-06-25 16.50, Caio Marcelo de Oliveira Filho wrote: > +test_expect_success 'commit.signoff config option' ' > + test_config commit.signoff true && > + echo "yet another content *narf*" >> foo && Minor nit: The > or >> should be written without a space, like this: >>foo -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] commit: add commit.signoff config option
Caio Marcelo de Oliveira Filho writes:
> A similar concern probably applies to format.signOff option. Would
> be sufficient to add a note about conscious act (like
> format.signOff has) to the config description?
I am generally in negative on automating this. This is not just you
but makes everybody else's S-o-b less and less meaningful ("Their
tool have ways to add that string randomly, and many of these ways
the user ends up adding that string without even conciously thinking
what they are doing. Does that string even mean anything anymore?").
One solution might be to make this not a straight-forward boolean,
but an option that superficially takes a string and treats one
specific value as "true" and everything else as "false", e.g.
[commit]
signoff = "I certify that all my work is licenseable under DCO"
I dunno.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] commit: add commit.signoff config option
Hi, > Hmm, I do not recall seeing v1 but that is OK. http://thread.gmane.org/gmane.comp.version-control.git/272635 http://thread.gmane.org/gmane.comp.version-control.git/272636 > The following immediately comes to mind. > > http://thread.gmane.org/gmane.comp.version-control.git/51754/focus=51780 Thanks for the reference, amazed that I ended up using the same title! >From the thread: > Even though these lines are not digitally signed, > the intent of adding a Signed-off-by: line with your name is > that you are certifying its origin, according to the definition > of DCO (see Documentation/SubmittingPatches). This should be a > conscious act from the signer's part, and making it automatic > with a config variable that you set once and forget makes it > much less meaningful. This is a fair point. However I've seen that in practice, in some cases it's easier to consider the DCO as the rules for contributing to the entire project. In those cases people tend to use commit templates or aliases or hooks, which in practice automate the signing off act anyway. A similar concern probably applies to format.signOff option. Would be sufficient to add a note about conscious act (like format.signOff has) to the config description? -- Caio Marcelo de Oliveira Filho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] commit: add commit.signoff config option
On 25/06, Junio C Hamano wrote: Caio Marcelo de Oliveira Filho writes: Hmm, I do not recall seeing v1 but that is OK. The following immediately comes to mind. http://thread.gmane.org/gmane.comp.version-control.git/51754/focus=51780 To be honest I'm not sure I buy that since we have `git commit -s`, which is just as easily added as a really simple git alias. -- Sincerely, Johannes Löthberg PGP Key ID: 0x50FB9B273A9D0BB5 https://theos.kyriasis.com/~kyrias/ signature.asc Description: PGP signature
Re: [PATCH v2] commit: add commit.signoff config option
Caio Marcelo de Oliveira Filho writes: > In projects that use Signed-off-by, it's convenient to include that line > in the commit message by default. The commit.signoff config option Hmm, I do not recall seeing v1 but that is OK. The following immediately comes to mind. http://thread.gmane.org/gmane.comp.version-control.git/51754/focus=51780 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
