Re: [PATCH v2 0/7] i18n for git-am, git-rebase and git-merge
2012/7/23 Junio C Hamano gits...@pobox.com: I find one test case failed, and correct it in PATCH 3/7. That test used i18ncmp already, so the update to expected string would be sufficient. I was worried if there were existing tests that have been expecting that the output from am/rebase/merge would not be i18n'ised and using test_cmp expect actual to compare their output with expected result. If build git with GETTEXT_POISON and test, lots of test cases failed. It seems that we haven't run these test cases for i18n for a long time. test of t0006-date.sh failed, because of i18n in commit 7d29af. 7d29a i18n: mark relative dates for translation test of t0040-parse-options.sh failed, because of i18n in commit 54e6dc7: 54e6d i18n: parseopt: lookup help and argument translations when showing usage I will try to fix them in next version of the patches. Test Summary Report --- ./t0006-date.sh(Wstat: 256 Tests: 45 Failed: 11) Failed tests: 1-11 Non-zero exit status: 1 ./t0050-filesystem.sh (Wstat: 0 Tests: 10 Failed: 0) TODO passed: 6 ./t0040-parse-options.sh (Wstat: 256 Tests: 36 Failed: 4) Failed tests: 1, 11-12, 27 Non-zero exit status: 1 ./t1502-rev-parse-parseopt.sh (Wstat: 256 Tests: 8 Failed: 1) Failed test: 1 Non-zero exit status: 1 ./t1450-fsck.sh(Wstat: 256 Tests: 16 Failed: 1) Failed test: 13 Non-zero exit status: 1 ./t1300-repo-config.sh (Wstat: 256 Tests: 104 Failed: 1) Failed test: 48 Non-zero exit status: 1 ./t2006-checkout-index-basic.sh(Wstat: 256 Tests: 2 Failed: 2) Failed tests: 1-2 Non-zero exit status: 1 ./t2107-update-index-basic.sh (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 ./t3004-ls-files-basic.sh (Wstat: 256 Tests: 4 Failed: 2) Failed tests: 3-4 Non-zero exit status: 1 ./t3200-branch.sh (Wstat: 256 Tests: 82 Failed: 2) Failed tests: 3, 10 Non-zero exit status: 1 ./t3406-rebase-message.sh (Wstat: 256 Tests: 6 Failed: 1) Failed test: 6 Non-zero exit status: 1 ./t3400-rebase.sh (Wstat: 256 Tests: 26 Failed: 4) Failed tests: 5-8 Non-zero exit status: 1 ./t3501-revert-cherry-pick.sh (Wstat: 256 Tests: 7 Failed: 2) Failed tests: 2-3 Non-zero exit status: 1 ./t4006-diff-mode.sh (Wstat: 256 Tests: 7 Failed: 4) Failed tests: 4-7 Non-zero exit status: 1 ./t4012-diff-binary.sh (Wstat: 256 Tests: 13 Failed: 2) Failed tests: 7-8 Non-zero exit status: 1 ./t4035-diff-quiet.sh (Wstat: 256 Tests: 20 Failed: 3) Failed tests: 16, 18, 20 Non-zero exit status: 1 ./t4120-apply-popt.sh (Wstat: 256 Tests: 8 Failed: 2) Failed tests: 3, 5 Non-zero exit status: 1 ./t4133-apply-filenames.sh (Wstat: 256 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 1 ./t4200-rerere.sh (Wstat: 256 Tests: 25 Failed: 2) Failed tests: 24-25 Non-zero exit status: 1 ./t4205-log-pretty-formats.sh (Wstat: 256 Tests: 13 Failed: 1) Failed test: 12 Non-zero exit status: 1 ./t4202-log.sh (Wstat: 256 Tests: 33 Failed: 1) Failed test: 33 Non-zero exit status: 1 ./t3903-stash.sh (Wstat: 256 Tests: 46 Failed: 1) Failed test: 45 Non-zero exit status: 1 ./t5300-pack-object.sh (Wstat: 256 Tests: 33 Failed: 2) Failed tests: 32-33 Non-zero exit status: 1 ./t5505-remote.sh (Wstat: 256 Tests: 68 Failed: 9) Failed tests: 2-3, 6-9, 13, 15, 46 Non-zero exit status: 1 ./t5530-upload-pack-error.sh (Wstat: 256 Tests: 10 Failed: 1) Failed test: 3 Non-zero exit status: 1 ./t6500-gc.sh (Wstat: 256 Tests: 3 Failed: 2) Failed tests: 2-3 Non-zero exit status: 1 ./t6042-merge-rename-corner-cases.sh (Wstat: 256 Tests: 26 Failed: 1) Failed test: 18 Non-zero exit status: 1 ./t6022-merge-rename.sh(Wstat: 256 Tests: 46 Failed: 3) Failed tests: 12, 15-16 Non-zero exit status: 1 ./t7008-grep-binary.sh (Wstat: 0 Tests: 20 Failed: 0) TODO passed: 12 ./t7508-status.sh (Wstat: 256 Tests: 76 Failed: 1) Failed test: 5 Non-zero exit status: 1 ./t7600-merge.sh (Wstat: 256 Tests: 48 Failed: 1) Failed test: 3 Non-zero exit status: 1 ./t9903-bash-prompt.sh (Wstat: 256 Tests:
Re: [PATCH v2 0/7] i18n for git-am, git-rebase and git-merge
On Mon, Jul 23, 2012 at 2:32 PM, Jiang Xin worldhello@gmail.com wrote: If build git with GETTEXT_POISON and test, lots of test cases failed. It seems that we haven't run these test cases for i18n for a long time. Gaah.. I should have resent the poison-fix series but so far procrastination is winning. Will do it soon. -- Duy -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/7] i18n for git-am, git-rebase and git-merge
2012/7/23 Nguyen Thai Ngoc Duy pclo...@gmail.com: On Mon, Jul 23, 2012 at 2:32 PM, Jiang Xin worldhello@gmail.com wrote: If build git with GETTEXT_POISON and test, lots of test cases failed. It seems that we haven't run these test cases for i18n for a long time. Gaah.. I should have resent the poison-fix series but so far procrastination is winning. Will do it soon. So, I will just try to fix what I am responsible for. -- Jiang Xin -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/7] i18n for git-am, git-rebase and git-merge
2012/7/23 Junio C Hamano gits...@pobox.com: I do not understand why many of these have Stefano's S-o-b in them. If you are relaying what Stefano originally wrote, then the author (i.e. From: ) and the first S-o-b would say Stefano, and your S-o-b will follow it, but that is probably not the case. I'll drop the S-o-b lines for now. It is because Stefano offers lots of help for correcting syntax errors and misspellings in the original commit logs. Should I use Reviewed-by tag instead of S-o-b? And in PATCH 3/7, there is a Ævar's S-o-b, it is because the workaround comes from Ævar's idea. Is this tag suitable? I think I should add a Reported-by tag for Vincent, as he report it first in this mail: http://thread.gmane.org/gmane.comp.version-control.git/199042 By the way, is there any existing test that needs to gain GETTEXT_POISON or test_i18ncmp with this change? I find one test case failed, and correct it in PATCH 3/7. -- Jiang Xin -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/7] i18n for git-am, git-rebase and git-merge
Jiang Xin worldhello@gmail.com writes: 2012/7/23 Junio C Hamano gits...@pobox.com: I do not understand why many of these have Stefano's S-o-b in them. If you are relaying what Stefano originally wrote, then the author (i.e. From: ) and the first S-o-b would say Stefano, and your S-o-b will follow it, but that is probably not the case. I'll drop the S-o-b lines for now. It is because Stefano offers lots of help for correcting syntax errors and misspellings in the original commit logs. Should I use Reviewed-by tag instead of S-o-b? Yeah, I guessed that you meant reviewed-by. And in PATCH 3/7, there is a Ævar's S-o-b, it is because the workaround comes from Ævar's idea. This one I remember the previous round, so didn't have any problem. By the way, is there any existing test that needs to gain GETTEXT_POISON or test_i18ncmp with this change? I find one test case failed, and correct it in PATCH 3/7. That test used i18ncmp already, so the update to expected string would be sufficient. I was worried if there were existing tests that have been expecting that the output from am/rebase/merge would not be i18n'ised and using test_cmp expect actual to compare their output with expected result. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
