Re: [PATCH v2 00/36] Combine t/helper binaries into a single one

[Johannes Schindelin]

Hi Junio,

On Tue, 27 Mar 2018, Junio C Hamano wrote:

> Johannes Schindelin  writes:
> 
> > This iteration, with the SQUASH??? I proposed (and that Junio will
> > hopefully pick up soon), works well on Windows.
> 
> Thanks; is that the "call it fn, as main is macro-ed away by us?"
> change?

Precisely.

Thanks,
Dscho

Re: [PATCH v2 00/36] Combine t/helper binaries into a single one

[Junio C Hamano]

Johannes Schindelin  writes:

> This iteration, with the SQUASH??? I proposed (and that Junio will
> hopefully pick up soon), works well on Windows.

Thanks; is that the "call it fn, as main is macro-ed away by us?"
change?

Re: [PATCH v2 00/36] Combine t/helper binaries into a single one

[Johannes Schindelin]

Hi Duy,

On Sat, 24 Mar 2018, Nguyễn Thái Ngọc Duy wrote:

> v2 fixes a couple of typos in commit messages and use the cmd__ prefix
> for test commands instead of test_, which avoids a naming conflict
> with the existing function test_lazy_init_name_hash
> 
> [the previous v2 send out was aborted because I messed it up with some
> other patches]

This iteration, with the SQUASH??? I proposed (and that Junio will
hopefully pick up soon), works well on Windows.

Thank you,
Dscho

Re: [PATCH v2 00/36] Combine t/helper binaries into a single one

[Junio C Hamano]

Nguyễn Thái Ngọc Duy   writes:

> v2 fixes a couple of typos in commit messages and use the cmd__ prefix
> for test commands instead of test_, which avoids a naming conflict
> with the existing function test_lazy_init_name_hash
>
> [the previous v2 send out was aborted because I messed it up with some
> other patches]

Yeah, I was wondering if the 7 v4 patches for --keep-pack should be
picked up, or I should just wait for a proper resubmission under its
own cover letter.

Re: [PATCH v2 00/36] Combine t/helper binaries into a single one

[Duy Nguyen]

On Sat, Mar 24, 2018 at 1:50 PM, Ævar Arnfjörð Bjarmason
 wrote:
>
> On Sat, Mar 24 2018, Nguyễn Thái Ngọc Duy wrote:
>
>> v2 fixes a couple of typos in commit messages and use the cmd__ prefix
>> for test commands instead of test_, which avoids a naming conflict
>> with the existing function test_lazy_init_name_hash
>>
>> [the previous v2 send out was aborted because I messed it up with some
>> other patches]
>
> This whole thing looks good to me, and I've applied it to my own build
> and run several modes (normal, split index etc.) of the test suite with
> it. Didn't get any problems.
>
> Micronit: If you M-x sort-lines (and I assume similar in other editors
> that have a function to sort stuff in ASCII order) the test-tool.c list
> you get this diff on top:
>
> diff --git a/t/helper/test-tool.c b/t/helper/test-tool.c
> index cd5e28b045..c38939b93e 100644
> --- a/t/helper/test-tool.c
> +++ b/t/helper/test-tool.c
> @@ -32,8 +32,8 @@ static struct test_cmd cmds[] = {
> { "revision-walking", cmd__revision_walking },
> { "run-command", cmd__run_command },
> { "scrap-cache-tree", cmd__scrap_cache_tree },
> -   { "sha1-array", cmd__sha1_array },
> { "sha1", cmd__sha1 },
> +   { "sha1-array", cmd__sha1_array },
> { "sigchain", cmd__sigchain },
> { "strcmp-offset", cmd__strcmp_offset },
> { "string-list", cmd__string_list },
>
> I think it makes sense to keep such lists in ASCII order (" before -)
> for subsequent edits where one or more things are added to the list and
> then sorted before submission.

Yeah, my brain just failed to see that sha1-array should be behind
sha1. Bad brain!
-- 
Duy

Re: [PATCH v2 00/36] Combine t/helper binaries into a single one

[Ævar Arnfjörð Bjarmason]

On Sat, Mar 24 2018, Nguyễn Thái Ngọc Duy wrote:

> v2 fixes a couple of typos in commit messages and use the cmd__ prefix
> for test commands instead of test_, which avoids a naming conflict
> with the existing function test_lazy_init_name_hash
>
> [the previous v2 send out was aborted because I messed it up with some
> other patches]

This whole thing looks good to me, and I've applied it to my own build
and run several modes (normal, split index etc.) of the test suite with
it. Didn't get any problems.

Micronit: If you M-x sort-lines (and I assume similar in other editors
that have a function to sort stuff in ASCII order) the test-tool.c list
you get this diff on top:

diff --git a/t/helper/test-tool.c b/t/helper/test-tool.c
index cd5e28b045..c38939b93e 100644
--- a/t/helper/test-tool.c
+++ b/t/helper/test-tool.c
@@ -32,8 +32,8 @@ static struct test_cmd cmds[] = {
{ "revision-walking", cmd__revision_walking },
{ "run-command", cmd__run_command },
{ "scrap-cache-tree", cmd__scrap_cache_tree },
-   { "sha1-array", cmd__sha1_array },
{ "sha1", cmd__sha1 },
+   { "sha1-array", cmd__sha1_array },
{ "sigchain", cmd__sigchain },
{ "strcmp-offset", cmd__strcmp_offset },
{ "string-list", cmd__string_list },

I think it makes sense to keep such lists in ASCII order (" before -)
for subsequent edits where one or more things are added to the list and
then sorted before submission.