Michael Haggerty mhag...@alum.mit.edu writes:
This is the (slightly inconsistent) status quo; make sure it doesn't
change by accident.
Interesting. So oldvalue being empty is we do not care what it
is (as opposed to we know it must not exist yet aka 0{40}), and
newvalue being empty is the same as delete it aka 0{40}.
That is unfortunate, but I agree it is a good idea to add a test for
it, so that we will notice when we decide to fix it.
Signed-off-by: Michael Haggerty mhag...@alum.mit.edu
---
t/t1400-update-ref.sh | 7 +++
1 file changed, 7 insertions(+)
diff --git a/t/t1400-update-ref.sh b/t/t1400-update-ref.sh
index a2015d0..208f56e 100755
--- a/t/t1400-update-ref.sh
+++ b/t/t1400-update-ref.sh
@@ -730,6 +730,13 @@ test_expect_success 'stdin -z fails update with bad ref
name' '
grep fatal: invalid ref format: ~a err
'
+test_expect_success 'stdin -z treats empty new value as zeros' '
+ git update-ref $a $m
+ printf $F update $a stdin
+ git update-ref -z --stdin stdin
+ test_must_fail git rev-parse --verify -q $a
+'
+
test_expect_success 'stdin -z fails update with no new value' '
printf $F update $a stdin
test_must_fail git update-ref -z --stdin stdin 2err
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
