Re: [PATCH v3 2/2] rebase-i: work around Windows CRLF line endings
Hi Junio, On Tue, 27 Oct 2015, Junio C Hamano wrote: > Johannes Schindelin writes: > > > My apologies: I forgot to spell out explicitly that this passes in Git > > for Windows 2.x' SDK: It does. > > Can you add that to the log message? Your cover letter may also want to > be updated for those who fish for the last version posted in the list > archive. Done, Johannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 2/2] rebase-i: work around Windows CRLF line endings
Johannes Schindelin writes: > On Tue, 27 Oct 2015, Johannes Schindelin wrote: > >> diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh >> index 5dfa16a..98eb49a 100755 >> --- a/t/t3404-rebase-interactive.sh >> +++ b/t/t3404-rebase-interactive.sh >> @@ -1261,7 +1261,7 @@ test_expect_success 'static check of bad SHA-1' ' >> test E = $(git cat-file commit HEAD | sed -ne \$p) >> ' >> >> -test_expect_failure 'editor saves as CR/LF' ' >> +test_expect_success 'editor saves as CR/LF' ' >> git checkout -b with-crlf && >> write_script add-crs.sh <<-\EOF && >> sed -e "s/\$/Q/" <"$1" | tr Q "\\015" >"$1".new && > > My apologies: I forgot to spell out explicitly that this passes in Git for > Windows 2.x' SDK: It does. Can you add that to the log message? Your cover letter may also want to be updated for those who fish for the last version posted in the list archive. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 2/2] rebase-i: work around Windows CRLF line endings
Hi, On Tue, 27 Oct 2015, Johannes Schindelin wrote: > diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh > index 5dfa16a..98eb49a 100755 > --- a/t/t3404-rebase-interactive.sh > +++ b/t/t3404-rebase-interactive.sh > @@ -1261,7 +1261,7 @@ test_expect_success 'static check of bad SHA-1' ' > test E = $(git cat-file commit HEAD | sed -ne \$p) > ' > > -test_expect_failure 'editor saves as CR/LF' ' > +test_expect_success 'editor saves as CR/LF' ' > git checkout -b with-crlf && > write_script add-crs.sh <<-\EOF && > sed -e "s/\$/Q/" <"$1" | tr Q "\\015" >"$1".new && My apologies: I forgot to spell out explicitly that this passes in Git for Windows 2.x' SDK: It does. Ciao, Johannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
