Re: [PATCH v4 00/12] unify appending of sob

2013-02-12 Thread Jonathan Nieder
Brandon Casey wrote:

 Round 4.

Yay.  I think this is cooked now and a good foundation for later
changes on top.

For what it's worth, with or without the two tweaks Junio suggested
(simplifying (cherry picked from detection, deferring introduction
of no_dup_sob variable until it is used),
Reviewed-by: Jonathan Nieder jrnie...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v4 00/12] unify appending of sob

2013-02-12 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes:

 Brandon Casey wrote:

 Round 4.

 Yay.  I think this is cooked now and a good foundation for later
 changes on top.

 For what it's worth, with or without the two tweaks Junio suggested
 (simplifying (cherry picked from detection, deferring introduction
 of no_dup_sob variable until it is used),
 Reviewed-by: Jonathan Nieder jrnie...@gmail.com

Yeah, I am inclined to merge this to 'next' without any tweak, and
let it cook and get polished incrementally.  I am not sure if we
have enough time to graduate it to 'master' for the upcoming
release, though.

Thanks.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html