Re: [PATCH v5 2/9] test: add test_write_lines helper
Jonathan Nieder writes: > Michael S. Tsirkin wrote: > >> --- a/t/test-lib-functions.sh >> +++ b/t/test-lib-functions.sh >> @@ -712,6 +712,11 @@ test_ln_s_add () { >> fi >> } >> >> +# This function writes out its parameters, one per line >> +test_write_lines () { >> +printf "%s\n" "$@"; >> +} >> + > > Thanks for fixing this. > > Nits: > > * no need for the trailing semicolon Good eyes. I was wondering if I wrote that (which I found very unlikely). > * it's probably worth documenting this in t/README as well so people >writing new test scripts know what it's about. Sounds like a good idea. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 2/9] test: add test_write_lines helper
Michael S. Tsirkin wrote: > --- a/t/test-lib-functions.sh > +++ b/t/test-lib-functions.sh > @@ -712,6 +712,11 @@ test_ln_s_add () { > fi > } > > +# This function writes out its parameters, one per line > +test_write_lines () { > + printf "%s\n" "$@"; > +} > + Thanks for fixing this. Nits: * no need for the trailing semicolon * it's probably worth documenting this in t/README as well so people writing new test scripts know what it's about. Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html