Re: [PATCH v6 1/2] blame: prevent error if range ends past end of file

2018-06-15 Thread Junio C Hamano
Isabella Stephens  writes:

>> Don't t800[12]-*.sh need adjustment for this change, too?
>
> Apologies. I will make sure I've run the whole test suite against
> my patches in future. I've sent through a 7th (and hopefully
> final) version.
>  

Thanks.  Will queue and hopefully we can carry this in 'pu' (and
later down to 'next' and to 'master').



Re: [PATCH v6 1/2] blame: prevent error if range ends past end of file

2018-06-15 Thread Isabella Stephens
> Don't t800[12]-*.sh need adjustment for this change, too?

Apologies. I will make sure I've run the whole test suite against my patches in 
future. I've sent through a 7th (and hopefully final) version.
 


Re: [PATCH v6 1/2] blame: prevent error if range ends past end of file

2018-05-31 Thread Junio C Hamano
isteph...@atlassian.com writes:

> From: Isabella Stephens 
>
> If the -L option is used to specify a line range in git blame, and the
> end of the range is past the end of the file, git will fail with a fatal
> error. This commit prevents such behavior - instead we display the blame
> for existing lines within the specified range. Tests are amended
> accordingly.
>
> This commit also fixes two corner cases. Blaming -L n,-(n+1) now blames
> the first n lines of a file rather than from n to the end of the file.
> Blaming -L ,-n will be treated as -L 1,-n and blame the first line of
> the file, rather than blaming the whole file.
>
> Signed-off-by: Isabella Stephens 
> ---
>  builtin/blame.c   |  4 ++--
>  line-range.c  |  2 +-
>  t/t8003-blame-corner-cases.sh | 12 
>  3 files changed, 11 insertions(+), 7 deletions(-)

Don't t800[12]-*.sh need adjustment for this change, too?