Re: [RFC PATCH 11/12] gc: automatically write commit-graph files
On Fri, Apr 20 2018, Jakub Narebski wrote: > Derrick Stoleewrites: > >> The commit-graph file is a very helpful feature for speeding up git >> operations. In order to make it more useful, write the commit-graph file >> by default during standard garbage collection operations. >> >> Add a 'gc.commitGraph' config setting that triggers writing a >> commit-graph file after any non-trivial 'git gc' command. > > Other than the question if 'gc.commitGraph' and 'core.commitGraph' > should be independent config variables, and the exact wording of the > git-gc docs, it looks good to me. Sans doc errors you pointed out in other places (you need to set core.commitGraph so it's read at all), I think it's very useful to have these split up. It's simliar to pack.useBitmaps & pack.writeBitmaps. Makes it easy to start writing them, and then have a quick toggle to turn it off if there's any issues rathen than go around deleting the files or making sure they're not written out.
Re: [RFC PATCH 11/12] gc: automatically write commit-graph files
Derrick Stoleewrites: > The commit-graph file is a very helpful feature for speeding up git > operations. In order to make it more useful, write the commit-graph file > by default during standard garbage collection operations. > > Add a 'gc.commitGraph' config setting that triggers writing a > commit-graph file after any non-trivial 'git gc' command. Other than the question if 'gc.commitGraph' and 'core.commitGraph' should be independent config variables, and the exact wording of the git-gc docs, it looks good to me. > Signed-off-by: Derrick Stolee > --- > Documentation/git-gc.txt | 4 > builtin/gc.c | 8 > 2 files changed, 12 insertions(+) > > diff --git a/Documentation/git-gc.txt b/Documentation/git-gc.txt > index 571b5a7e3c..17dd654a59 100644 > --- a/Documentation/git-gc.txt > +++ b/Documentation/git-gc.txt > @@ -119,6 +119,10 @@ The optional configuration variable `gc.packRefs` > determines if > it within all non-bare repos or it can be set to a boolean value. > This defaults to true. > > +The optional configuration variable 'gc.commitGraph' determines if > +'git gc' runs 'git commit-graph write'. This can be set to a boolean > +value. This defaults to false. > + > The optional configuration variable `gc.aggressiveWindow` controls how > much time is spent optimizing the delta compression of the objects in > the repository when the --aggressive option is specified. The larger [...]