Re: Bug: format-patch MIME boundary not added to cover letter when attach enabled
On Mon, Apr 30, 2018 at 12:30:57PM +0900, Junio C Hamano wrote: > Thanks. It is true that the current output from the tool is corrupt > mime multi-part, and we need to do something about it. > > I however have to wonder if it even makes sense for --cover to pay > attention to --attach and produce the cover template that has "BLURB > HERE" etc. in a multi-part format. Shouldn't we be making a simple > plain text file instead? I agree that multipart/mixed is not a useful content-type for only one plain text part. I have a patch to add the trailing boundary, but I think you make a good argument that perhaps omitting the entire multipart portion would be better. I'll have to work on this after work, so expect a patch later today. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204 signature.asc Description: PGP signature
Re: Bug: format-patch MIME boundary not added to cover letter when attach enabled
"brian m. carlson" writes: > On Sun, Apr 29, 2018 at 09:40:13PM -0400, Patrick Hemmer wrote: >> When you use `git format-patch --cover-letter --attach`, the cover >> letter does not have the trailing MIME boundary. RFC2046 states that the >> last part must be followed by a closing boundary. This causes some email >> clients (Thunderbird in my case) to discard the message body. >> This is experienced with git 2.16.3. > > Thanks for reporting this. I can confirm this with a reasonably recent > next. Let me see if I can come up with a patch. Thanks. It is true that the current output from the tool is corrupt mime multi-part, and we need to do something about it. I however have to wonder if it even makes sense for --cover to pay attention to --attach and produce the cover template that has "BLURB HERE" etc. in a multi-part format. Shouldn't we be making a simple plain text file instead?
Re: Bug: format-patch MIME boundary not added to cover letter when attach enabled
On Sun, Apr 29, 2018 at 09:40:13PM -0400, Patrick Hemmer wrote: > When you use `git format-patch --cover-letter --attach`, the cover > letter does not have the trailing MIME boundary. RFC2046 states that the > last part must be followed by a closing boundary. This causes some email > clients (Thunderbird in my case) to discard the message body. > This is experienced with git 2.16.3. Thanks for reporting this. I can confirm this with a reasonably recent next. Let me see if I can come up with a patch. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204 signature.asc Description: PGP signature
