Re: Fwd: [PATCH 4/5] Replace {pre,suf}fixcmp() with {starts,ends}_with()
Christian Couder writes: > Tell me if I can do something. I think the tip of 'pu' with cc/starts-n-ends-with-endgame is in fairly a good shape. The evil merge there may need to be updated over time, but I think I can manage. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Fwd: [PATCH 4/5] Replace {pre,suf}fixcmp() with {starts,ends}_with()
On Wed, Dec 4, 2013 at 11:02 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Christian Couder writes: >> >>> Ok, the commit is in the use_starts_ends_with branch on this github repo: >>> >>> https://github.com/chriscool/git.git >> >> I looked at the patches, and they looked alright. The endgame needs >> to be on a separate topic to be held until a distant future, though. >> >> Will queue. Thanks. Great! > It turns out that, naturally, there are many new uses of prefixcmp > in the topics in flight. I can manage, but adjusting all of them > would not look too pretty X-<. Tell me if I can do something. I can prepare patches for the topics in flight in 'next' for example. Thanks, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Fwd: [PATCH 4/5] Replace {pre,suf}fixcmp() with {starts,ends}_with()
Junio C Hamano writes: > Christian Couder writes: > >> Ok, the commit is in the use_starts_ends_with branch on this github repo: >> >> https://github.com/chriscool/git.git > > I looked at the patches, and they looked alright. The endgame needs > to be on a separate topic to be held until a distant future, though. > > Will queue. Thanks. It turns out that, naturally, there are many new uses of prefixcmp in the topics in flight. I can manage, but adjusting all of them would not look too pretty X-<. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Fwd: [PATCH 4/5] Replace {pre,suf}fixcmp() with {starts,ends}_with()
Christian Couder writes: > Ok, the commit is in the use_starts_ends_with branch on this github repo: > > https://github.com/chriscool/git.git I looked at the patches, and they looked alright. The endgame needs to be on a separate topic to be held until a distant future, though. Will queue. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Fwd: [PATCH 4/5] Replace {pre,suf}fixcmp() with {starts,ends}_with()
On Tue, Dec 03, 2013 at 09:24:40PM +0100, Christian Couder wrote: > > I skimmed the patch and didn't notice any problems. It's > > whitespace-damaged by gmail, of course. The simplest thing is probably > > to just point us at a public repo with the commit, if you have one. > > Ok, the commit is in the use_starts_ends_with branch on this github repo: > > https://github.com/chriscool/git.git Thanks. I looked more carefully this time, using a few greps to classify the surrounding context (since the script you used for the update could conceivably miss some really odd misuse). The whole thing looks good to me. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Fwd: [PATCH 4/5] Replace {pre,suf}fixcmp() with {starts,ends}_with()
On Tue, Dec 3, 2013 at 1:46 PM, Jeff King wrote:
>
> This made it through to me, but not the list. There are at least two
> things going on:
>
> 1. The message is 172K, which is over the 100K limit imposed by vger;
> the list is silently dropping it.
>
> 2. In my case, the direct mail was being flagged by spam because it
> contains the blacklisted domain "old.name". Which of course is not
> a domain at all but rather this code:
>
>old.name = old.path + strlen("refs/heads/");
>
> I've tweaked my server.
>
> I can't say why it wasn't getting to Junio via direct mail. Maybe the
> same spam thing, or maybe something else.
[...]
> I skimmed the patch and didn't notice any problems. It's
> whitespace-damaged by gmail, of course. The simplest thing is probably
> to just point us at a public repo with the commit, if you have one.
Ok, the commit is in the use_starts_ends_with branch on this github repo:
https://github.com/chriscool/git.git
Thanks,
Christian.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Fwd: [PATCH 4/5] Replace {pre,suf}fixcmp() with {starts,ends}_with()
On Tue, Dec 03, 2013 at 08:03:39AM +0100, Christian Couder wrote:
> I am trying to forward this patch from my gmail address, as it doesn't
> seem to go through when I send it from my home machine.
This made it through to me, but not the list. There are at least two
things going on:
1. The message is 172K, which is over the 100K limit imposed by vger;
the list is silently dropping it.
2. In my case, the direct mail was being flagged by spam because it
contains the blacklisted domain "old.name". Which of course is not
a domain at all but rather this code:
old.name = old.path + strlen("refs/heads/");
I've tweaked my server.
I can't say why it wasn't getting to Junio via direct mail. Maybe the
same spam thing, or maybe something else.
> From: Christian Couder
> Date: Sun, Dec 1, 2013 at 8:49 AM
> Subject: [PATCH 4/5] Replace {pre,suf}fixcmp() with {starts,ends}_with()
> To: christian.cou...@gmail.com
>
> This patch was generated automatically using the following
> commands:
>
> git grep --name-only prefixcmp | grep -v '\.h' | grep -v 'strbuf.c' |
> xargs perl -pi -e 's/!prefixcmp\(/starts_with\(/g'
> git grep --name-only prefixcmp | grep -v '\.h' | grep -v 'strbuf.c' |
> xargs perl -pi -e 's/prefixcmp\(/!starts_with\(/g'
> git grep --name-only suffixcmp | grep -v '\.h' | grep -v 'strbuf.c' |
> xargs perl -pi -e 's/!suffixcmp\(/ends_with\(/g'
> git grep --name-only suffixcmp | grep -v '\.h' | grep -v 'strbuf.c' |
> xargs perl -pi -e 's/suffixcmp\(/!ends_with\(/g'
>
> It was generated on version 1.8.5 of the git codebase.
I skimmed the patch and didn't notice any problems. It's
whitespace-damaged by gmail, of course. The simplest thing is probably
to just point us at a public repo with the commit, if you have one.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
