Re: What's cooking in git.git (Mar 2015, #07; Fri, 20)
brian m. carlson sand...@crustytoothpaste.net writes: On Fri, Mar 20, 2015 at 08:20:58PM -0700, Junio C Hamano wrote: I had an impression that the series may see at least one reroll to polish it further before it gets ready for 'next', as I only saw discussions on the tangent (e.g. possible futures) and didn't see serious reviews of the code that we will actually be using. If people have suggestions on how to improve it, I'm eager to hear them and submit a reroll or follow-up patches, as appropriate. Making changes now would be much better than having to do it down the line. Yeah, agreed on the last point, and that is why I kept it out of 'next' before people have enough time to think about it. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: What's cooking in git.git (Mar 2015, #07; Fri, 20)
On Fri, Mar 20, 2015 at 08:20:58PM -0700, Junio C Hamano wrote: I had an impression that the series may see at least one reroll to polish it further before it gets ready for 'next', as I only saw discussions on the tangent (e.g. possible futures) and didn't see serious reviews of the code that we will actually be using. If people have suggestions on how to improve it, I'm eager to hear them and submit a reroll or follow-up patches, as appropriate. Making changes now would be much better than having to do it down the line. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187 signature.asc Description: Digital signature
Re: What's cooking in git.git (Mar 2015, #07; Fri, 20)
On Mar 20, 2015, at 15:02, Junio C Hamano wrote: * bc/object-id (2015-03-13) 10 commits - apply: convert threeway_stage to object_id - patch-id: convert to use struct object_id - commit: convert parts to struct object_id - diff: convert struct combine_diff_path to object_id - bulk-checkin.c: convert to use struct object_id - zip: use GIT_SHA1_HEXSZ for trailers - archive.c: convert to use struct object_id - bisect.c: convert leaf functions to use struct object_id - define utility functions for object IDs - define a structure for object IDs Identify parts of the code that knows that we use SHA-1 hash to name our objects too much, and use (1) symbolic constants instead of hardcoded 20 as byte count and/or (2) use struct object_id instead of unsigned char [20] for object names. Will cook in 'next'. Has this been merged to 'next'? Even fetching github.com/gitster/ git.git I'm only seeing it in pu: $ git rev-parse bc/object-id d07d4ab401173a10173f2747cf5e0f074b6d2b39 $ git branch --contains d07d4ab401173a10173f2747cf5e0f074b6d2b39 --all bc/object-id jch pu remotes/github2/pu remotes/gob-private/pu remotes/gph/pu remotes/ko/pu remotes/repo/pu -Kyle -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: What's cooking in git.git (Mar 2015, #07; Fri, 20)
On Mar 20, 2015, at 16:29, Stefan Beller wrote: On Fri, Mar 20, 2015 at 4:24 PM, Kyle J. McKay mack...@gmail.com wrote: On Mar 20, 2015, at 15:02, Junio C Hamano wrote: * bc/object-id (2015-03-13) 10 commits [snip] Will cook in 'next'. Has this been merged to 'next'? Usually Junio writes the mail first and then does a git push all the branches just before being done for the day. At least that's my suspicion as an observer of the timing when git fetch returns new shiny stuff and when these emails are sent. I would expect that if it said, Will merge to 'next'. However the What's cooking in git.git (Mar 2015, #06; Tue, 17) also says Will cook in 'next' for this topic so I think that perhaps it's fallen through the cracks somehow. -Kyle -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: What's cooking in git.git (Mar 2015, #07; Fri, 20)
On Fri, Mar 20, 2015 at 4:24 PM, Kyle J. McKay mack...@gmail.com wrote: Has this been merged to 'next'? Usually Junio writes the mail first and then does a git push all the branches just before being done for the day. At least that's my suspicion as an observer of the timing when git fetch returns new shiny stuff and when these emails are sent. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: What's cooking in git.git (Mar 2015, #07; Fri, 20)
Kyle J. McKay mack...@gmail.com writes: Will cook in 'next'. Has this been merged to 'next'? Even fetching github.com/gitster/git.git I'm only seeing it in pu: That was a short-hand for will merge and cook in 'next' ;-) I had an impression that the series may see at least one reroll to polish it further before it gets ready for 'next', as I only saw discussions on the tangent (e.g. possible futures) and didn't see serious reviews of the code that we will actually be using. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
