Re: bug report, v1.7.12.1 -- Documentation/git-bundle.xml:130: parser error

2012-09-30 Thread Hugh Esco
Your are correct.  That is apparently the issue:

git@pbx:~$ asciidoc --version
asciidoc 8.2.7

This server is still running Debian Lenny.
Not sure when I will be able to rebuild it.  

My apologies for spamming your bug reporting list 
with all of that.  I now have source installs of git 
and gitolite installed and presumably working on this 
server and promise not to bother you further with 
that issue.

-- Hugh Esco

Date: Sun, 30 Sep 2012 14:02:09 -0400
From: Jeff King 
To: Junio C Hamano 
Cc: he...@yourmessagedelivered.com, git@vger.kernel.org
Subject: Re: bug report, v1.7.12.1 -- Documentation/git-bundle.xml:130:
 parser error

On Sun, Sep 30, 2012 at 12:34:18AM -0700, Junio C Hamano wrote:

> I suspect that a tilde inside literal `` environment is mishandled
> in your versions of the documentation toolchain.  Either you would
> need to upgrade some tool in the toolchain, or we would need patches
> to the source that would look like:
> 
>   -such as `master~1` cannot be packaged,...
> +such as `master{tilde}1` cannot be packaged,...
> 
> to work around this problem if the version of the problematic tool
> you are using is widespread.

That would not work, as commit 6cf378f turned off no-inline-literal, and
modern asciidoc would not expand that "{tilde}" at all. My guess is that
Hugh is using a version of asciidoc older than 8.4.1, which was the
first version to understand inline literals.

This came up already once before:

  http://thread.gmane.org/gmane.comp.version-control.git/198733

where the culprit was older third-party RPMs on RHEL5. It can be worked
around by upgrading asciidoc, or using "make quick-install-doc" to pull
the pre-built versions.

-Peff

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bug report, v1.7.12.1 -- Documentation/git-bundle.xml:130: parser error

2012-09-30 Thread Jeff King
On Sun, Sep 30, 2012 at 12:34:18AM -0700, Junio C Hamano wrote:

> I suspect that a tilde inside literal `` environment is mishandled
> in your versions of the documentation toolchain.  Either you would
> need to upgrade some tool in the toolchain, or we would need patches
> to the source that would look like:
> 
>   -such as `master~1` cannot be packaged,...
> +such as `master{tilde}1` cannot be packaged,...
> 
> to work around this problem if the version of the problematic tool
> you are using is widespread.

That would not work, as commit 6cf378f turned off no-inline-literal, and
modern asciidoc would not expand that "{tilde}" at all. My guess is that
Hugh is using a version of asciidoc older than 8.4.1, which was the
first version to understand inline literals.

This came up already once before:

  http://thread.gmane.org/gmane.comp.version-control.git/198733

where the culprit was older third-party RPMs on RHEL5. It can be worked
around by upgrading asciidoc, or using "make quick-install-doc" to pull
the pre-built versions.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bug report, v1.7.12.1 -- Documentation/git-bundle.xml:130: parser error

2012-09-30 Thread Junio C Hamano
Hugh Esco  writes:

> doing a source install of git v1.7.12.1, 
> on the `make all doc` step, I get:
>
> xmlto: input does not validate (status 1)
> /usr/local/git-git-51993a4/Documentation/git-bundle.xml:130: parser error : 
> Opening and ending tag mismatch: subscript line 130 and literal
> such as master1 cannot be packaged, but are 
> perfec
>  ^
> /usr/local/git-git-51993a4/Documentation/git-bundle.xml:134: parser error : 
> Opening and ending tag mismatch: literal line 134 and subscript
> specified explicitly (e.g. ^master10), or 
> implici
>^
> make[1]: *** [git-bundle.1] Error 1
> make[1]: Leaving directory `/usr/local/git-git-51993a4/Documentation'
> make: *** [doc] Error 2
>
> ---
> and the patch which permitted me to proceed
> ---
>
> 130c130
>> such as master1 cannot be 
>> packaged, but are perfectly suitable for

PLEASE STOP.

git-anything.xml files are _not_ the source files we edit, so
patches to them are not useful for us.

I suspect that a tilde inside literal `` environment is mishandled
in your versions of the documentation toolchain.  Either you would
need to upgrade some tool in the toolchain, or we would need patches
to the source that would look like:

-such as `master~1` cannot be packaged,...
+such as `master{tilde}1` cannot be packaged,...

to work around this problem if the version of the problematic tool
you are using is widespread.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html