Re: v3 [PATCH 2/2] status:introduce status.branch to enable --branch by default

[Ramkumar Ramachandra]

y...@ensimag.imag.fr wrote:
 [...]

Good change.

 diff --git a/t/t7508-status.sh b/t/t7508-status.sh
 index 9a07f15..958617a 100755
 --- a/t/t7508-status.sh
 +++ b/t/t7508-status.sh

I expected one test.  Two, at most.  This is a bit overzealous.  I
don't mind leaving it as it is, but as a note for the future: this
kind of overkill is not necessarily a good thing; it makes it hard to
add/remove tests, multiple tests fail when one tiny feature doesn't
work as expected, and the testsuite takes longer to run.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: v3 [PATCH 2/2] status:introduce status.branch to enable --branch by default

[Matthieu Moy]

Ramkumar Ramachandra artag...@gmail.com writes:

 y...@ensimag.imag.fr wrote:
 [...]

 Good change.

 diff --git a/t/t7508-status.sh b/t/t7508-status.sh
 index 9a07f15..958617a 100755
 --- a/t/t7508-status.sh
 +++ b/t/t7508-status.sh

 I expected one test.  Two, at most.  This is a bit overzealous. 

I actually had this discussion with Jorge (in real life). I first
thought this was too much, and I think we already removed one rendundant
test. But actually, this should be two at least, since you really want
to test whether --[no-]branch takes precedence over status.branch or
not, in addition to testing status.branch alone.

The last two tests are less important, but they also test something (in
short: what happens when branch.status is set to something other than
true). So I think it makes sense to keep them.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html