Re: js/empty-config-section-fix, was Re: What's cooking in git.git (May 2018, #03; Wed, 23)

[Jeff King]

On Mon, May 28, 2018 at 01:20:41PM +0200, Johannes Schindelin wrote:

> On Mon, 28 May 2018, Junio C Hamano wrote:
> 
> > Johannes Schindelin  writes:
> > 
> > > On Thu, 24 May 2018, Junio C Hamano wrote:
> > >
> > >> * js/empty-config-section-fix (2018-05-18) 1 commit
> > >>  - config: a user-provided invalid section is not a BUG
> > >> 
> > >>  Error codepath fix.
> > >> 
> > >>  Will merge to 'next'.
> > >
> > > As a hotfix, maybe we can fast-track it to master?
> > 
> > Hotfix is a proposed fix for an issue that is so important to be a
> > showstopper.  This one must be fixed before the final release, but I
> > do not think it's not that urgent to force us to drop everything
> > else and merge it to master immediately.
> 
> Well, in this case, a user might report a BUG when they simply have an
> invalid config.
> 
> I do not care all that much, but Peff (who reported this) might.

I think it's fine to just fix it before release. Both the likelihood of
it happening and its severity are pretty low.

-Peff

Re: js/empty-config-section-fix, was Re: What's cooking in git.git (May 2018, #03; Wed, 23)

[Johannes Schindelin]

Hi Junio,

On Mon, 28 May 2018, Junio C Hamano wrote:

> Johannes Schindelin  writes:
> 
> > On Thu, 24 May 2018, Junio C Hamano wrote:
> >
> >> * js/empty-config-section-fix (2018-05-18) 1 commit
> >>  - config: a user-provided invalid section is not a BUG
> >> 
> >>  Error codepath fix.
> >> 
> >>  Will merge to 'next'.
> >
> > As a hotfix, maybe we can fast-track it to master?
> 
> Hotfix is a proposed fix for an issue that is so important to be a
> showstopper.  This one must be fixed before the final release, but I
> do not think it's not that urgent to force us to drop everything
> else and merge it to master immediately.

Well, in this case, a user might report a BUG when they simply have an
invalid config.

I do not care all that much, but Peff (who reported this) might.

Ciao,
Dscho

Re: js/empty-config-section-fix, was Re: What's cooking in git.git (May 2018, #03; Wed, 23)

[Junio C Hamano]

Johannes Schindelin  writes:

> Hi Junio,
>
> On Thu, 24 May 2018, Junio C Hamano wrote:
>
>> * js/empty-config-section-fix (2018-05-18) 1 commit
>>  - config: a user-provided invalid section is not a BUG
>> 
>>  Error codepath fix.
>> 
>>  Will merge to 'next'.
>
> As a hotfix, maybe we can fast-track it to master?

Hotfix is a proposed fix for an issue that is so important to be a
showstopper.  This one must be fixed before the final release, but I
do not think it's not that urgent to force us to drop everything
else and merge it to master immediately.

js/empty-config-section-fix, was Re: What's cooking in git.git (May 2018, #03; Wed, 23)

[Johannes Schindelin]

Hi Junio,

On Thu, 24 May 2018, Junio C Hamano wrote:

> * js/empty-config-section-fix (2018-05-18) 1 commit
>  - config: a user-provided invalid section is not a BUG
> 
>  Error codepath fix.
> 
>  Will merge to 'next'.

As a hotfix, maybe we can fast-track it to master?

Thanks,
Dscho