Re: [git-buildpackage] git-buildpackage-rpm patchset 2016-04-14

2016-04-18 Thread Markus Lehtonen
On Sun, 2016-04-17 at 17:14 +0200, Guido Günther wrote:
> Hi Markus,
> On Thu, Apr 14, 2016 at 01:22:03PM +0300, Markus Lehtonen wrote:
> > Hi Guido,
> > 
> > Just pinging again: have you had the chance to look at any of my
> > patches?
> > 
> > I've rebased my branches at 
> > https://github.com/marquiz/git-buildpackage-rpm:
> >   experimental-rpm
> >   feature/argparse
> >   feature/buildpackage-rpm
> >   feature/fixes
> >   feature/import-srpm
> >   feature/misc
> >   feature/pq-rpm
> >   feature/python-pkg-resources
> >   feature/rpm-ch
> > 
> 
> I've looked at the argparse stuff a while back and will merge that as
> soon as I get around to have more than a couple of minutes to work on
> this stuff (Debconf 16 latest I suppose).
> 
> Cheers and thanks a lot,

That would be great. Hopefully I'm not causing too much stress. I took
a very quick glance at the argparse branch and adjusted some
docstrings. I pushed the new version to Github.

Thanks,
  Markus

___
git-buildpackage mailing list
git-buildpackage@lists.sigxcpu.org
http://lists.sigxcpu.org/mailman/listinfo/git-buildpackage


Re: [git-buildpackage] [PATCH] Add --git-packaging-exclude to gbp buildpackage-rpm

2016-02-04 Thread Markus Lehtonen
Hi,



On 04/02/16 20:25, "git-buildpackage on behalf of Guido Günther" 
 
wrote:

>Hi,
>On Thu, Feb 04, 2016 at 06:34:31PM +0100, Tzafrir Cohen wrote:
>> Add an option to exclude copying some of the files from the source tree
>> to the packaging directory (a single regular expression).
>> 
>> This can be handy when running gbp buildpackage-rpm from a complete
>> source tree in a non-native mode and and some files in the top-level
>> directory can't or should not be copies to the packaging directory.
>
>Thanks for the patch! Can you describe the concrete use case a bit so we
>can check if "gbp buildpackage" needs this as well or if we need it at
>all?
>Markus do you have comments on this or maybe a similar patch in your queue?

I'm also wondering what would be the real use case for this? Why wouldn't you 
want to use all files from the packaging directory? If there are unneeded 
unwanted files in the packaging directory the correct thing to do (IMO) is just 
to remove those files (or move them somewhere else so that they won't be 
copied).


Thanks,
   Markus

___
git-buildpackage mailing list
git-buildpackage@lists.sigxcpu.org
http://lists.sigxcpu.org/mailman/listinfo/git-buildpackage


Re: [git-buildpackage] git-buildpackage-rpm patchset 2015-11-20

2016-01-28 Thread Markus Lehtonen
Hi Guido,

On Mon, 2016-01-25 at 19:27 +0100, Guido Günther wrote:
> Hi Markus,
> On Mon, Jan 25, 2016 at 01:43:57PM +0200, Markus Lehtonen wrote:
> [..snip..]
> > >Again, I have two new patches in the feature/fixes branch (cherry-picked 
> > >from my experimental-rpm branch) which would partly solve
> > >https://github.com/agx/git-buildpackage/pull/16
> > 
> > Just pinging. Any progress in reviewing any of my patches?
> 
> Other things like the LTS switch from Squeeze to Wheezy keep pushing in
> so I only did fixes that actually popped up during that work (or at
> $dayjob).
> 
> I had a look at some of your patches but need to find some time to
> comment on them in a qualified fashion.

I slightly improved my "Command: redirect stdout/stderr to
sys.stdout/stderr" patch in my 'feature/buildpackage' branch


> I also did tried to not make changes that make it _harder_ to apply
> them.
> 
> Hope to get around to review this soonish,

I rebased all my branches and pushed them to gihub. The recent PEP8
fixes in upstream caused a bit more rebase-pain than normal, but nothing
big :)


Cheers,
  Markus

___
git-buildpackage mailing list
git-buildpackage@lists.sigxcpu.org
http://lists.sigxcpu.org/mailman/listinfo/git-buildpackage


Re: [git-buildpackage] git-buildpackage-rpm patchset 2015-11-20

2016-01-25 Thread Markus Lehtonen
Hi Guido,



On 04/01/16 11:29, "Markus Lehtonen" <markus.lehto...@linux.intel.com> wrote:
>
>On 14/12/15 15:18, "git-buildpackage on behalf of Markus Lehtonen" 
><git-buildpackage-boun...@lists.sigxcpu.org on behalf of 
>markus.lehto...@linux.intel.com> wrote:
>
>>Hi Guido,
>>
>>On Sat, 2015-12-12 at 22:40 +0100, Guido Günther wrote:
>>> Hi Markus,
>>> On Wed, Dec 09, 2015 at 09:34:09AM +0200, Markus Lehtonen wrote:
>>> [..snip..]
>>> > >I will remove this pristine-tar test for now. I'll let you know when I 
>>> > >have an updated patchset available.
>>> > 
>>> > I ended up changing the pristine-tar branches in the test repos instead 
>>> > of dropping the test. Updated patch can be found in my 
>>> > 'feature/buildpackage-rpm' branch. All tests should pass now.`> 
>>> 
>>> Applied that part. Thanks! I'll look at your patches silencing the RPM
>>> parts of the test suite so that we can get back to zero default noise.
>>
>>Great!
>>
>>I made yet another attempt in suppressing the test noise. Please see the
>>'Command: redirect stdout/stderr to sys.stdout/stderr' patch in my
>>'feature/buildpackage-rpm' branch.
>
>Have you had the chance to look at these?
>
>
>Again, I have two new patches in the feature/fixes branch (cherry-picked from 
>my experimental-rpm branch) which would partly solve
>https://github.com/agx/git-buildpackage/pull/16

Just pinging. Any progress in reviewing any of my patches?

Cheers,
  Markus

___
git-buildpackage mailing list
git-buildpackage@lists.sigxcpu.org
http://lists.sigxcpu.org/mailman/listinfo/git-buildpackage