[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #42: AMQNET-619: Handle remote detach properly for sender link

[GitBox]

michaelandrepearce merged pull request #42: AMQNET-619: Handle remote detach 
properly for sender link
URL: https://github.com/apache/activemq-nms-amqp/pull/42
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #42: AMQNET-619: Handle remote detach properly for sender link

[GitBox]

Havret commented on a change in pull request #42: AMQNET-619: Handle remote 
detach properly for sender link
URL: https://github.com/apache/activemq-nms-amqp/pull/42#discussion_r331738433
 
 

 ##
 File path: src/NMS.AMQP/Provider/Amqp/AmqpProducer.cs
 ##
 @@ -53,13 +53,13 @@ public Task Attach()
 };
 
 string linkName = info.Id + ":" + target.Address;
-var taskCompletionSource = new TaskCompletionSource();
-senderLink = new SenderLink(session.UnderlyingSession, linkName, 
frame, (link, attach) => { taskCompletionSource.SetResult(true); });
+TaskCompletionSource tsc = new TaskCompletionSource();
 
 Review comment:
   Hope it's ok now.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #44: AMQNET-620: Initialize ConnectionFactory properly with System.Uri overload

[GitBox]

michaelandrepearce merged pull request #44: AMQNET-620: Initialize 
ConnectionFactory properly with System.Uri overload
URL: https://github.com/apache/activemq-nms-amqp/pull/44
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #42: AMQNET-619: Handle remote detach properly for sender link

[GitBox]

michaelandrepearce commented on a change in pull request #42: AMQNET-619: 
Handle remote detach properly for sender link
URL: https://github.com/apache/activemq-nms-amqp/pull/42#discussion_r331736022
 
 

 ##
 File path: src/NMS.AMQP/Provider/Amqp/AmqpProducer.cs
 ##
 @@ -53,13 +53,13 @@ public Task Attach()
 };
 
 string linkName = info.Id + ":" + target.Address;
-var taskCompletionSource = new TaskCompletionSource();
-senderLink = new SenderLink(session.UnderlyingSession, linkName, 
frame, (link, attach) => { taskCompletionSource.SetResult(true); });
+TaskCompletionSource tsc = new TaskCompletionSource();
 
 Review comment:
   You made further changes...:s the name is still shortened  i meant to put it 
back to var taskCompletionService so there is no change in this line.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services