[GitHub] [activemq-artemis] jbertram commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface

2019-08-15 Thread GitBox
jbertram commented on issue #2792: NO-JIRA: Javadoc for 
ActiveMQServerMessagePlugin interface
URL: https://github.com/apache/activemq-artemis/pull/2792#issuecomment-521689923
 
 
   I think what you wrote looks good. I wouldn't go as far as saying that using 
a `ThreadLocal` is a *good* idea, but it should work nonetheless. :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [activemq-artemis] jbertram commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface

2019-08-13 Thread GitBox
jbertram commented on issue #2792: NO-JIRA: Javadoc for 
ActiveMQServerMessagePlugin interface
URL: https://github.com/apache/activemq-artemis/pull/2792#issuecomment-520923490
 
 
   I think this would be better in the User Guide rather than the JavaDoc for 
this class.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services