[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2802: ARTEMIS-2457 implement ring queue

2019-08-23 Thread GitBox
michaelandrepearce commented on issue #2802: ARTEMIS-2457 implement ring queue
URL: https://github.com/apache/activemq-artemis/pull/2802#issuecomment-524217658
 
 
   Ill try make something this weekend to show what im meaning


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2802: ARTEMIS-2457 implement ring queue

2019-08-23 Thread GitBox
michaelandrepearce commented on issue #2802: ARTEMIS-2457 implement ring queue
URL: https://github.com/apache/activemq-artemis/pull/2802#issuecomment-524213706
 
 
   Is there added ability to update the size? I really would like this sorted 
before merge as it stands with it not being implemented inside the main 
queueimpl i beleive it makes it very hard to implement. Thus my original 
feedback / query to why have it as independent type, instead of implementing 
within queueimpl.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2802: ARTEMIS-2457 implement ring queue

2019-08-20 Thread GitBox
michaelandrepearce commented on issue #2802: ARTEMIS-2457 implement ring queue
URL: https://github.com/apache/activemq-artemis/pull/2802#issuecomment-523184603
 
 
   In QPID both size in message count can be configured / or size in total 
bytes.  I cannot see how we can set the latter?
   
   What's the reason to make this a brand new queue type entirely over just 
making it something configurable, i ask as it means cannot change an existing 
queue into a ring queue without deleting and recreating, where as having it a 
setting in QueueImpl like almost all others would give the dynamic ability. 
   
   On top of the last comment, can we dynamically update the size, e.g. 
increase or decrease its limit, so that if incorrectly sized it can be tuned, 
without need of re-creating.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services