[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache
michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#issuecomment-521563091 @jbertram re: > BTW, the issue I saw wasn't a leak, per se. It was simply unwanted accumulation based on the way it was designed. Won't we get similar issue on the tempoary queue set thats used to track temp queues? I guess that could probably move into the session object, so theyre cleaned up as a session is closed, which is anyhow the lifetime of a temporary queue anyhow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache
michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#issuecomment-521563091 @jbertram re: > BTW, the issue I saw wasn't a leak, per se. It was simply unwanted accumulation based on the way it was designed. Won't we get similar issue on the tempoary queue set thats used to track temp queues in connection? I guess that could probably move into the session object, so theyre cleaned up as a session is closed, which is anyhow the lifetime of a temporary queue anyhow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache
michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#issuecomment-521563091 @jbertram re: > BTW, the issue I saw wasn't a leak, per se. It was simply unwanted accumulation based on the way it was designed. Won't we get similar issue on the tempoary queue set thats used to track temp queues? I guess that could probably move into the session object, so theyre cleaned up as a session is closed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache
michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#issuecomment-521562542 @jbertram this was a quick scrap togeather of what i was trying to describe in review comment on your pr. Im happy to complete it fully for you, but it wont be till next week. Im more than happy if you need this done faster and wish to just take it and complete it (e.g. dont worry about keeping my authorship) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
