[GitHub] [activemq-nms-amqp] michaelpearce-gain commented on a change in pull request #38: AMQNET-616: Add TCP Keep-Alive support

2019-09-25 Thread GitBox 
michaelpearce-gain commented on a change in pull request #38: AMQNET-616: Add 
TCP Keep-Alive support
URL: https://github.com/apache/activemq-nms-amqp/pull/38#discussion_r328002168
 
 

 ##
 File path: src/NMS.AMQP/Transport/SecureTransportContext.cs
 ##
 @@ -37,8 +37,8 @@ namespace Apache.NMS.AMQP.Transport
 internal class SecureTransportContext : TransportContext, 
ISecureTransportContext
 {
 
-private readonly static List SupportedProtocols;
-private readonly static Dictionary 
SupportedProtocolValues;
+private static readonly List SupportedProtocols;
 
 Review comment:
   ah i didnt spot that


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-nms-amqp] michaelpearce-gain commented on a change in pull request #38: AMQNET-616: Add TCP Keep-Alive support

2019-09-25 Thread GitBox 
michaelpearce-gain commented on a change in pull request #38: AMQNET-616: Add 
TCP Keep-Alive support
URL: https://github.com/apache/activemq-nms-amqp/pull/38#discussion_r327971083
 
 

 ##
 File path: src/NMS.AMQP/Transport/SecureTransportContext.cs
 ##
 @@ -37,8 +37,8 @@ namespace Apache.NMS.AMQP.Transport
 internal class SecureTransportContext : TransportContext, 
ISecureTransportContext
 {
 
-private readonly static List SupportedProtocols;
-private readonly static Dictionary 
SupportedProtocolValues;
+private static readonly List SupportedProtocols;
 
 Review comment:
   why change to static? isnt that dangerous as what occurs if multiple CF's or 
contexts needing different values


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services