[GitHub] [activemq-website] jbonofre merged pull request #17: Fix the ordering in the security advisories page
jbonofre merged pull request #17: Fix the ordering in the security advisories page URL: https://github.com/apache/activemq-website/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis-native] MrEasy commented on issue #4: ARTEMIS-2426 Added Bundle-Native code header
MrEasy commented on issue #4: ARTEMIS-2426 Added Bundle-Native code header URL: https://github.com/apache/activemq-artemis-native/pull/4#issuecomment-543044283 @clebertsuconic It is not adding the so to the JAR - the 2 so files are already part of the JAR. It only adds Bundle-Headers to the Manifest, allowing the so being loaded from JAR directly in an OSGi-environment, instead of having to extract it and placing it in an external-lib folder. See issue description for some more info. What was the line in XML, you had to remove? Had no issue building it on my side. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis-native] MrEasy edited a comment on issue #4: ARTEMIS-2426 Added Bundle-Native code header
MrEasy edited a comment on issue #4: ARTEMIS-2426 Added Bundle-Native code header URL: https://github.com/apache/activemq-artemis-native/pull/4#issuecomment-543044283 @clebertsuconic It is not adding the so to the JAR - the 2 so files are already part of the JAR. It only adds Bundle-Headers to the Manifest, allowing the so being loaded from JAR directly in an OSGi-environment, instead of having to extract it and placing it in an external-lib folder. See issue description for some more info. Uh, added one element too much, sorry 'bout that. Will update the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #2865: ARTEMIS-2521 add documentation for role-mapping
jbertram commented on issue #2865: ARTEMIS-2521 add documentation for role-mapping URL: https://github.com/apache/activemq-artemis/pull/2865#issuecomment-543218430 Thanks for the PR! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #2865: ARTEMIS-2521 add documentation for role-mapping
asfgit closed pull request #2865: ARTEMIS-2521 add documentation for role-mapping URL: https://github.com/apache/activemq-artemis/pull/2865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] asfgit merged pull request #2865: ARTEMIS-2521 add documentation for role-mapping
asfgit merged pull request #2865: ARTEMIS-2521 add documentation for role-mapping URL: https://github.com/apache/activemq-artemis/pull/2865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-website] coheigea opened a new pull request #17: Fix the ordering in the security advisories page
coheigea opened a new pull request #17: Fix the ordering in the security advisories page URL: https://github.com/apache/activemq-website/pull/17 Currently, a 2017 advisory is under 2018, and a 2015 CVE is under 2017. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis-native] clebertsuconic merged pull request #4: ARTEMIS-2426 Added Bundle-Native code header
clebertsuconic merged pull request #4: ARTEMIS-2426 Added Bundle-Native code header URL: https://github.com/apache/activemq-artemis-native/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #2851: ARTEMIS-2503 Improve wildcards for the roles access match
brusdev commented on a change in pull request #2851: ARTEMIS-2503 Improve
wildcards for the roles access match
URL: https://github.com/apache/activemq-artemis/pull/2851#discussion_r335870325
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/JMXAccessControlList.java
##
@@ -25,12 +25,22 @@
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
+import org.apache.activemq.artemis.core.config.WildcardConfiguration;
+import org.apache.activemq.artemis.core.settings.HierarchicalRepository;
+import
org.apache.activemq.artemis.core.settings.impl.HierarchicalObjectRepository;
+
public class JMXAccessControlList {
private Access defaultAccess = new Access("*");
- private Map domainAccess = new HashMap<>();
+ private HierarchicalRepository domainAccess;
private ConcurrentHashMap> whitelist = new
ConcurrentHashMap<>();
+ public JMXAccessControlList() {
+ WildcardConfiguration domainAccessWildcardConfiguration = new
WildcardConfiguration();
Review comment:
I pushed a commit to simplify the improvement.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] rcsilva83 commented on issue #2760: ARTEMIS-2420 Adding support for DLA/DLQ prefix for wildcard addresses
rcsilva83 commented on issue #2760: ARTEMIS-2420 Adding support for DLA/DLQ prefix for wildcard addresses URL: https://github.com/apache/activemq-artemis/pull/2760#issuecomment-543332194 Please, support suffix on "dead-letter-address-auto-create" element too. We prefer "Queue.Name.DLQ" so DLQ queues stay close to the original ones in alphabetical order. This is how our current ActiveMQ is configured. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #2850: ARTEMIS-2504 implement retroactive addresses
jbertram commented on issue #2850: ARTEMIS-2504 implement retroactive addresses URL: https://github.com/apache/activemq-artemis/pull/2850#issuecomment-543349109 I added a simple failover test and push. Everything looks OK as far as I can tell. As far as the "destructive testing" you mentioned goes, I've done a bit more than what is captured in the tests, but nothing I could categorize as industrial grade (e.g. no huge loads on big hardware). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jbertram edited a comment on issue #2850: ARTEMIS-2504 implement retroactive addresses
jbertram edited a comment on issue #2850: ARTEMIS-2504 implement retroactive addresses URL: https://github.com/apache/activemq-artemis/pull/2850#issuecomment-543349109 I added a simple failover test and pushed. Everything looks OK as far as I can tell. As far as the "destructive testing" you mentioned goes, I've done a bit more than what is captured in the tests, but nothing I could categorize as industrial grade (e.g. no huge loads on big hardware). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2850: ARTEMIS-2504 implement retroactive addresses
michaelandrepearce commented on issue #2850: ARTEMIS-2504 implement retroactive addresses URL: https://github.com/apache/activemq-artemis/pull/2850#issuecomment-543381734 No further comments from me atm other bits and bobs can always be added later in future prs /version and refined over time. Thanks for this @jbertram was prob the last big ticket for artemis to be in feature parity with activemq5. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] gabrielmcoelho opened a new pull request #398: Remove out-of-bounds index comparison
gabrielmcoelho opened a new pull request #398: Remove out-of-bounds index comparison URL: https://github.com/apache/activemq/pull/398 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
