[GitHub] [hive] pmadhukar-cloudera commented on a change in pull request #2151: HIVE-24933: Replication fails for transactional tables having same na…

[GitBox]

pmadhukar-cloudera commented on a change in pull request #2151:
URL: https://github.com/apache/hive/pull/2151#discussion_r624864844



##
File path: 
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java
##
@@ -1406,4 +1439,114 @@ public static Table tableIfExists(ImportTableDesc 
tblDesc, Hive db) throws HiveE
 }
   }
 
+  public static class LoadTableStateWrapper {

Review comment:
   DelayExecUtil has been renamed to LoadTableStateWrapper.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

[GitHub] [hive] scarlin-cloudera opened a new pull request #2238: HIVE-25085: MetaStore Clients no longer shared across sessions.

[GitBox]

scarlin-cloudera opened a new pull request #2238:
URL: https://github.com/apache/hive/pull/2238


   Testing this fix, please do not review yet.
   
   
   
   ### What changes were proposed in this pull request?
   
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

[GitHub] [hive] rbalamohan commented on a change in pull request #2234: HIVE-25075: Hive::loadPartitionInternal establishes HMS connection fo…

[GitBox]

rbalamohan commented on a change in pull request #2234:
URL: https://github.com/apache/hive/pull/2234#discussion_r624700779



##
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##
@@ -3202,7 +3202,7 @@ public void loadTable(Path loadPath, String tableName, 
LoadFileType loadFileType
 //for fullAcid we don't want to delete any files even for OVERWRITE 
see HIVE-14988/HIVE-17361
 boolean isSkipTrash = MetaStoreUtils.isSkipTrash(tbl.getParameters());
 boolean needRecycle = !tbl.isTemporary()
-&& 
ReplChangeManager.shouldEnableCm(Hive.get().getDatabase(tbl.getDbName()), 
tbl.getTTable());

Review comment:
   Fixed in recent commit. Fine with the invocation for PartitionIterable 
as "new PartitionIterable(Hive.get()" (since it could have pointed earlier to 
diff db).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

[GitHub] [hive] ashish-kumar-sharma commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

[GitBox]

ashish-kumar-sharma commented on pull request #2211:
URL: https://github.com/apache/hive/pull/2211#issuecomment-830789617


   @kishendas  Can you please review the PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org