Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
difin commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1595460479 ## pom.xml: ## @@ -180,8 +180,8 @@ 8.0.31 42.7.3 21.3.0.0 -2.3 -1.8.5 +5.9 Review Comment: Hi @dongjoon-hyun, opencsv changes were removed from this PR and were done separately. The differences in the results of tests are still present. I did a few additional checks: - The same differences are present when Hive statistics are enabled and when they are disabled. - With the `decimal_vgby` table used as a source in the test in Parquet format instead of Orc, the differences are absent (so it is an additional confirmation that it is something related to Orc). - I dumped the content of the `decimal_vgby` table with and without Orc upgrade and they were the same, which is odd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
sonarcloud[bot] commented on PR #5218: URL: https://github.com/apache/hive/pull/5218#issuecomment-2102085437 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5218) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5218=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5218=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5218=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5218) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
sonarcloud[bot] commented on PR #5218: URL: https://github.com/apache/hive/pull/5218#issuecomment-2101814730 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5218) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5218=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5218=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5218=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5218) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
difin commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1594886623 ## ql/src/test/queries/clientpositive/insert_values_orig_table_use_metadata.q: ## @@ -1,5 +1,6 @@ --! qt:dataset:src --! qt:dataset:alltypesorc +--! qt:replace:/(\s+totalSize\s+)\S+(\s+)/$1#Masked#$2/ Review Comment: Done, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
difin commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1594880751 ## ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_5.q.out: ## @@ -404,7 +404,7 @@ Table Parameters: numFiles2 numRows 10 rawDataSize 0 - totalSize #Masked# + totalSize #Masked# Review Comment: Done, thanks ## ql/src/test/results/clientpositive/llap/stats_part.q.out: ## @@ -161,7 +161,7 @@ Table Parameters: numPartitions 0 numRows 0 rawDataSize 0 - totalSize #Masked# + totalSize #Masked# Review Comment: Done, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
difin commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1594880884 ## ql/src/test/results/clientpositive/llap/insert_values_orig_table_use_metadata.q.out: ## @@ -108,7 +108,7 @@ Table Parameters: numFiles0 numRows 0 rawDataSize 0 - totalSize #Masked# + totalSize #Masked# Review Comment: Done, thanks ## ql/src/test/queries/clientpositive/stats_part.q: ## @@ -1,3 +1,5 @@ +-- Mask the totalSize value as it can have slight variability, causing test flakiness +--! qt:replace:/(\s+totalSize\s+)\S+(\s+)/$1#Masked#$2/ Review Comment: Done, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
difin commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1594879746 ## ql/src/test/queries/clientpositive/materialized_view_create_rewrite_5.q: ## @@ -1,3 +1,4 @@ +--! qt:replace:/(\s+totalSize\s+)\S+(\s+)/$1#Masked#$2/ Review Comment: Done, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
zhangbutao commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1594859688 ## ql/src/test/results/clientpositive/llap/stats_part.q.out: ## @@ -161,7 +161,7 @@ Table Parameters: numPartitions 0 numRows 0 rawDataSize 0 - totalSize #Masked# + totalSize #Masked# Review Comment: Need to regenerate this out once remove the `totalSize`. ## ql/src/test/results/clientpositive/llap/insert_values_orig_table_use_metadata.q.out: ## @@ -108,7 +108,7 @@ Table Parameters: numFiles0 numRows 0 rawDataSize 0 - totalSize #Masked# + totalSize #Masked# Review Comment: Need to regenerate this out once remove the `totalSize`. ## ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_5.q.out: ## @@ -404,7 +404,7 @@ Table Parameters: numFiles2 numRows 10 rawDataSize 0 - totalSize #Masked# + totalSize #Masked# Review Comment: Need to regenerate this out once remove the `totalSize`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
zhangbutao commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1594858800 ## ql/src/test/queries/clientpositive/stats_part.q: ## @@ -1,3 +1,5 @@ +-- Mask the totalSize value as it can have slight variability, causing test flakiness +--! qt:replace:/(\s+totalSize\s+)\S+(\s+)/$1#Masked#$2/ Review Comment: `totalSize` is not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
zhangbutao commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1594858429 ## ql/src/test/queries/clientpositive/materialized_view_create_rewrite_5.q: ## @@ -1,3 +1,4 @@ +--! qt:replace:/(\s+totalSize\s+)\S+(\s+)/$1#Masked#$2/ Review Comment: `totalSize` is not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
zhangbutao commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1594858047 ## ql/src/test/queries/clientpositive/insert_values_orig_table_use_metadata.q: ## @@ -1,5 +1,6 @@ --! qt:dataset:src --! qt:dataset:alltypesorc +--! qt:replace:/(\s+totalSize\s+)\S+(\s+)/$1#Masked#$2/ Review Comment: `totalSize` is not needed. We can remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
difin commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1591599492 ## pom.xml: ## @@ -180,8 +180,8 @@ 8.0.31 42.7.3 21.3.0.0 -2.3 -1.8.5 +5.9 Review Comment: You are welcome, @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
dongjoon-hyun commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1591598003 ## pom.xml: ## @@ -180,8 +180,8 @@ 8.0.31 42.7.3 21.3.0.0 -2.3 -1.8.5 +5.9 Review Comment: Thank you, @difin . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
difin commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1591581795 ## pom.xml: ## @@ -180,8 +180,8 @@ 8.0.31 42.7.3 21.3.0.0 -2.3 -1.8.5 +5.9 Review Comment: I added opencsv changes because Hive wasn't able to compile without them. Hive has a code that depends on opencsv version that was coming from Orc 1.8.5 and it is not in 1.9.3. I created a separate PR for upgrading opencsv https://github.com/apache/hive/pull/5240 Once it gets merged, I will update this PR and remove opencsv changes from it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
dongjoon-hyun commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1591200307 ## pom.xml: ## @@ -180,8 +180,8 @@ 8.0.31 42.7.3 21.3.0.0 -2.3 -1.8.5 +5.9 Review Comment: May I ask why do you change `opencsv` under the PR title, `HIVE-28224: Upgrade Orc version in Hive to 1.9.3`, @difin ? Could you proceed to upgrade `opencsv` library independently before upgrading ORC? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
difin commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1589376344 ## ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_10.q.out: ## @@ -79,17 +79,17 @@ STAGE PLANS: TableScan alias: t1 filterExpr: (b = 1) (type: boolean) - Statistics: Num rows: 69 Data size: 13710 Basic stats: COMPLETE Column stats: NONE + Statistics: Num rows: 70 Data size: #Masked# Basic stats: COMPLETE Column stats: NONE Review Comment: The "Num rows" is a calculated estimate by dividing data size by average row size. Previously data size was 13,710 and now it is 13,720. Average row size = 196 Before Orc upgrade it was: 13,710 / 196 = 69.??? - hence the value of "Num rows" was 69. Now: 13720 / 196 = 70 So basically the reason for num rows change is that Data size value increased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
difin commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1589376344 ## ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_10.q.out: ## @@ -79,17 +79,17 @@ STAGE PLANS: TableScan alias: t1 filterExpr: (b = 1) (type: boolean) - Statistics: Num rows: 69 Data size: 13710 Basic stats: COMPLETE Column stats: NONE + Statistics: Num rows: 70 Data size: #Masked# Basic stats: COMPLETE Column stats: NONE Review Comment: The "Num rows" is calculated estimate by dividing data size by average row size. Previously data size was 13,710 and now it is 13,720. Average row size = 196 Before Orc upgrade it was: 13,710 / 196 = 69.??? - hence the value of "Num rows" was 69. Now: 13720 / 196 = 70 So basically the reason for num rows change is that Data size value increased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
difin commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1589416170 ## ql/src/test/results/clientpositive/llap/vector_decimal_aggregate.q.out: ## @@ -847,4 +847,4 @@ FROM (SELECT cint, POSTHOOK: type: QUERY POSTHOOK: Input: default@decimal_vgby_small A masked pattern was here -95165244160 +95767761728 Review Comment: This difference is caused by the previous differences in STDDEV_POP(cdecimal1) and STDDEV_SAMP(cdecimal1) fields -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
difin commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1589376344 ## ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_10.q.out: ## @@ -79,17 +79,17 @@ STAGE PLANS: TableScan alias: t1 filterExpr: (b = 1) (type: boolean) - Statistics: Num rows: 69 Data size: 13710 Basic stats: COMPLETE Column stats: NONE + Statistics: Num rows: 70 Data size: #Masked# Basic stats: COMPLETE Column stats: NONE Review Comment: That's number of stats rows that changed. Not sure how. The number of data rows is 2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
difin commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1589374087 ## ql/src/test/queries/clientpositive/insert_values_orig_table_use_metadata.q: ## @@ -1,5 +1,6 @@ --! qt:dataset:src --! qt:dataset:alltypesorc +--! qt:replace:/(\s+totalSize\s+)\S+(\s+)/$1#Masked#$2/ Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
ayushtkn commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1588649396 ## ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_10.q.out: ## @@ -79,17 +79,17 @@ STAGE PLANS: TableScan alias: t1 filterExpr: (b = 1) (type: boolean) - Statistics: Num rows: 69 Data size: 13710 Basic stats: COMPLETE Column stats: NONE + Statistics: Num rows: 70 Data size: #Masked# Basic stats: COMPLETE Column stats: NONE Review Comment: How did number of rows changed with ORC upgrade? ## ql/src/test/results/clientpositive/llap/vector_decimal_aggregate.q.out: ## @@ -847,4 +847,4 @@ FROM (SELECT cint, POSTHOOK: type: QUERY POSTHOOK: Input: default@decimal_vgby_small A masked pattern was here -95165244160 +95767761728 Review Comment: here also the result of the query is changing ## ql/src/test/results/clientpositive/llap/vector_decimal_aggregate.q.out: ## @@ -403,7 +403,7 @@ POSTHOOK: Input: default@decimal_vgby 626923679 10249723.4027027027 -9778.9513513514 10541.052529728710.29399661106318 5742.091453237337 5744.897264034264 102411645.74615384615400-11712.27692307692300 12625.047599774612.329148046874977988 6877.318722794881 6880.679250101608 6981 3 5831542.2692483780 -515.6210729730 5830511.0271024320 1943503.6757008107 2749258.455012492 3367140.1929065133 3 6984454.2110976920 -617.56077692307690 6983219.08954384584620 2327739.69651461528207 3292794.4113115156 4032833.0678006653 7622 5831542.2692483780 1531.2194054054 5833073.4886537834 2916536.7443268917 2915005.5249214866 4122440.3477364695 2 6984454.2110976920 1833.94569230769250 6986288.1567869250 3493144.07839499984625 3491310.1327026924 4937458.140118757 -NULL 30729318.4351351351 -4298.15135135145018444.1081079808 1633.60810810806667 5695.483082135323 5696.410307714464 3072 11160.71538461538500-5147.907692307693006010604.30769230735360 1956.57692307692297 6821.495748565151 6822.606289190915 +NULL 30729318.4351351351 -4298.15135135145018444.1081079808 1633.60810810806667 5695.483082135325 5696.4103077144655 3072 11160.71538461538500-5147.907692307693006010604.30769230735360 1956.57692307692297 6821.4957485651385 6822.606289190904 Review Comment: query result is changing here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
sonarcloud[bot] commented on PR #5218: URL: https://github.com/apache/hive/pull/5218#issuecomment-2091935035 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5218) **Quality Gate passed** Issues  [5 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5218=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5218=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5218=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5218) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
sonarcloud[bot] commented on PR #5218: URL: https://github.com/apache/hive/pull/5218#issuecomment-2090767547 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5218) **Quality Gate passed** Issues  [5 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5218=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5218=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5218=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5218) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
ayushtkn commented on code in PR #5218: URL: https://github.com/apache/hive/pull/5218#discussion_r1586980099 ## ql/src/test/queries/clientpositive/insert_values_orig_table_use_metadata.q: ## @@ -1,5 +1,6 @@ --! qt:dataset:src --! qt:dataset:alltypesorc +--! qt:replace:/(\s+totalSize\s+)\S+(\s+)/$1#Masked#$2/ Review Comment: I don't think these lines are required now, this masking is automatically done now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
sonarcloud[bot] commented on PR #5218: URL: https://github.com/apache/hive/pull/5218#issuecomment-2088999689 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5218) **Quality Gate passed** Issues  [5 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5218=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5218=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5218=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5218) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
sonarcloud[bot] commented on PR #5218: URL: https://github.com/apache/hive/pull/5218#issuecomment-2088573829 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5218) **Quality Gate passed** Issues  [5 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5218=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5218=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5218=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5218) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
sonarcloud[bot] commented on PR #5218: URL: https://github.com/apache/hive/pull/5218#issuecomment-2085585576 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5218) **Quality Gate passed** Issues  [5 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5218=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5218=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5218=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5218) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
sonarcloud[bot] commented on PR #5218: URL: https://github.com/apache/hive/pull/5218#issuecomment-2083433079 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5218) **Quality Gate passed** Issues  [5 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5218=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5218=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5218=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5218) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
sonarcloud[bot] commented on PR #5218: URL: https://github.com/apache/hive/pull/5218#issuecomment-2080191445 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5218) **Quality Gate passed** Issues  [5 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5218=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5218=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5218=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5218) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]
difin opened a new pull request, #5218: URL: https://github.com/apache/hive/pull/5218 ### What changes were proposed in this pull request? Upgrading Orc version in Hive to the latest version that supports Java 8 - 1.9.3 ### Why are the changes needed? To keep Hive updated with latest Orc developments ### Does this PR introduce _any_ user-facing change? No ### Is the change a dependency upgrade? ### How was this patch tested? Pre-commit testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
