Re: [PR] HIVE-27928: Release branch cleanup [hive]
sonarcloud[bot] commented on PR #5116: URL: https://github.com/apache/hive/pull/5116#issuecomment-1977032318 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5116) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5116=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5116=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5116=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5116) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-27928: Release branch cleanup [hive]
deniskuzZ commented on PR #5116: URL: https://github.com/apache/hive/pull/5116#issuecomment-1976741394 ref https://github.com/apache/hive/pull/4916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-27928: Release branch cleanup [hive]
deniskuzZ merged PR #4916: URL: https://github.com/apache/hive/pull/4916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-27928: Release branch cleanup [hive]
deniskuzZ commented on code in PR #4916: URL: https://github.com/apache/hive/pull/4916#discussion_r1421428685 ## standalone-metastore/metastore-server/src/main/sql/mysql/upgrade.order.mysql: ## @@ -19,4 +19,4 @@ 3.2.0-to-4.0.0-alpha-1 4.0.0-alpha-1-to-4.0.0-alpha-2 4.0.0-alpha-2-to-4.0.0-beta-1 -4.0.0-beta-1-to-4.0.0-beta-2 +4.0.0-beta-1-to-4.0.0 Review Comment: 1. yes, as someone might have upgraded to alpha/beta release. The current schema evolution strategy is version-centric. We've tried to improve on that, but haven't received any feedback from HMS experts: https://github.com/apache/hive/pull/4060 2. You are right, since there was no 3.2 release we might drop those scripts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-27928: Release branch cleanup [hive]
deniskuzZ commented on code in PR #4916: URL: https://github.com/apache/hive/pull/4916#discussion_r1421428685 ## standalone-metastore/metastore-server/src/main/sql/mysql/upgrade.order.mysql: ## @@ -19,4 +19,4 @@ 3.2.0-to-4.0.0-alpha-1 4.0.0-alpha-1-to-4.0.0-alpha-2 4.0.0-alpha-2-to-4.0.0-beta-1 -4.0.0-beta-1-to-4.0.0-beta-2 +4.0.0-beta-1-to-4.0.0 Review Comment: 1. yes, as someone might have upgraded to alpha/beta release. The current schema evolution strategy is version-centric. We've tried to improve on that, but haven't received any feedback from HMS experts: https://github.com/apache/hive/pull/4060 2. You are right, since there was no 3.2 release we might drop those scripts. However, I am not sure what if someone releases 3.2 and then decides to upgrade to 4.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-27928: Release branch cleanup [hive]
deniskuzZ commented on code in PR #4916: URL: https://github.com/apache/hive/pull/4916#discussion_r1421428685 ## standalone-metastore/metastore-server/src/main/sql/mysql/upgrade.order.mysql: ## @@ -19,4 +19,4 @@ 3.2.0-to-4.0.0-alpha-1 4.0.0-alpha-1-to-4.0.0-alpha-2 4.0.0-alpha-2-to-4.0.0-beta-1 -4.0.0-beta-1-to-4.0.0-beta-2 +4.0.0-beta-1-to-4.0.0 Review Comment: 1. yes, as someone might have upgraded to alpha/beta release. The current schema evolution strategy is version-centric. We've tried to improve on that, but haven't received any feedback from HMS experts: https://github.com/apache/hive/pull/4060 2. You are right, since there was no 3.2 release we should drop those scripts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-27928: Release branch cleanup [hive]
pan3793 commented on code in PR #4916: URL: https://github.com/apache/hive/pull/4916#discussion_r1418525954 ## standalone-metastore/metastore-server/src/main/sql/mysql/upgrade.order.mysql: ## @@ -19,4 +19,4 @@ 3.2.0-to-4.0.0-alpha-1 4.0.0-alpha-1-to-4.0.0-alpha-2 4.0.0-alpha-2-to-4.0.0-beta-1 -4.0.0-beta-1-to-4.0.0-beta-2 +4.0.0-beta-1-to-4.0.0 Review Comment: I have two questions here: 1. is it necessary to retain the alpha/beta versions in the upgrading history? 2. should it be 3.1.0-to-4.0.0? as 3.2.0 was not released, there is no guarantee of db schema freeze -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-27928: Release branch cleanup [hive]
sonarcloud[bot] commented on PR #4916: URL: https://github.com/apache/hive/pull/4916#issuecomment-1840633019 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive=4916) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4916=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4916=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4916=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_hive=4916=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_hive=4916=duplicated_lines_density=list) No Duplication information  The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more [here](https://docs.sonarsource.com/sonarcloud/appendices/scanner-environment/) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-27928: Release branch cleanup [hive]
deniskuzZ commented on PR #4916: URL: https://github.com/apache/hive/pull/4916#issuecomment-1840267204 > you will add 4.0.0 metastore scripts here then branch out & then move the version again to 4.0.1-SNAPSHOT? i've created that just for the branch-4.0, but looks like I need to merge it first to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-27928: Release branch cleanup [hive]
sonarcloud[bot] commented on PR #4916: URL: https://github.com/apache/hive/pull/4916#issuecomment-1839844056 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive=4916) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4916=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4916=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4916=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_hive=4916=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_hive=4916=duplicated_lines_density=list) No Duplication information  The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more [here](https://docs.sonarsource.com/sonarcloud/appendices/scanner-environment/) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-27928: Release branch cleanup [hive]
sonarcloud[bot] commented on PR #4916: URL: https://github.com/apache/hive/pull/4916#issuecomment-1839233193 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive=4916) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4916=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4916=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4916=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=4916=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_hive=4916=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_hive=4916=duplicated_lines_density=list) No Duplication information  The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more [here](https://docs.sonarsource.com/sonarcloud/appendices/scanner-environment/) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
