Re: [PR] HIVE-28099: Fix logging in HMS benchmarks [hive]
kuczoram merged PR #5112: URL: https://github.com/apache/hive/pull/5112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28099: Fix logging in HMS benchmarks [hive]
sonarcloud[bot] commented on PR #5112: URL: https://github.com/apache/hive/pull/5112#issuecomment-1991856148 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5112) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5112=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5112=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5112=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5112) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28099: Fix logging in HMS benchmarks [hive]
sonarcloud[bot] commented on PR #5112: URL: https://github.com/apache/hive/pull/5112#issuecomment-1988484359 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5112) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5112=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5112=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5112=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5112) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28099: Fix logging in HMS benchmarks [hive]
InvisibleProgrammer commented on code in PR #5112: URL: https://github.com/apache/hive/pull/5112#discussion_r1519296883 ## standalone-metastore/metastore-tools/metastore-benchmarks/pom.xml: ## @@ -139,30 +143,46 @@ -maven-assembly-plugin +org.apache.maven.plugins +maven-shade-plugin - - - - org.apache.hadoop.hive.metastore.tools.BenchmarkTool - true - - - -jar-with-dependencies - - hmsbench - -make-assembly-hclient - package - - single + shade + + hmsbench + + + + org.apache.hadoop.hive.metastore.tools.BenchmarkTool + + + + + + *:* + +META-INF/*.SF +META-INF/*.DSA +META-INF/*.RSA + + + + + + +com.github.edwgiz + maven-shade-plugin.log4j2-cachefile-transformer Review Comment: Good idea. Thank you, fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28099: Fix logging in HMS benchmarks [hive]
abstractdog commented on code in PR #5112: URL: https://github.com/apache/hive/pull/5112#discussion_r1517434941 ## standalone-metastore/metastore-tools/metastore-benchmarks/pom.xml: ## @@ -139,30 +143,46 @@ -maven-assembly-plugin +org.apache.maven.plugins +maven-shade-plugin - - - - org.apache.hadoop.hive.metastore.tools.BenchmarkTool - true - - - -jar-with-dependencies - - hmsbench - -make-assembly-hclient - package - - single + shade + + hmsbench + + + + org.apache.hadoop.hive.metastore.tools.BenchmarkTool + + + + + + *:* + +META-INF/*.SF +META-INF/*.DSA +META-INF/*.RSA + + + + + + +com.github.edwgiz + maven-shade-plugin.log4j2-cachefile-transformer Review Comment: this is told to be part of official apache log4j2 instead of com.github.edwgiz, according to readme here: https://github.com/edwgiz/maven-shaded-log4j-transformer?tab=readme-ov-file can we move to that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28099: Fix logging in HMS benchmarks [hive]
zratkai commented on PR #5112: URL: https://github.com/apache/hive/pull/5112#issuecomment-1985301532 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28099: Fix logging in HMS benchmarks [hive]
sonarcloud[bot] commented on PR #5112: URL: https://github.com/apache/hive/pull/5112#issuecomment-1974941273 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5112) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5112=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5112=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5112=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5112) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28099: Fix logging in HMS benchmarks [hive]
InvisibleProgrammer closed pull request #5108: HIVE-28099: Fix logging in HMS benchmarks URL: https://github.com/apache/hive/pull/5108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
