Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
sunchao commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2094642723 Sorry for the delay @pan3793 . I just sent out RC1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
pan3793 commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2094575223 @sunchao can we have the next RC for 2.3.10? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
sunchao commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2084436105 Merged, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
sunchao merged PR #5204: URL: https://github.com/apache/hive/pull/5204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
sunchao commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2084420623 oops, thanks @pan3793 - let me check the commits in branch-2.3 and see which commit caused the regression -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
pan3793 commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2084405831 @sunchao the failed tests are not caused by this patch, I opened another dummy PR based on the latest branch-2.3, and got the same failures https://github.com/apache/hive/pull/5225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
sunchao commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2081301602 Hmm @pan3793 I tried the tests again for 2 times, and each time there were over 40 tests failing, which is quite more than the normal 26. Could you double-check whether there is anything we should fix here? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
sunchao commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2075428065 OK, just re-triggered CI to confirm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
pan3793 commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2074014828 @sunchao based on the CI results of this PR branch, I think the failure tests should be flaky cases http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/activity?branch=PR-5204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
sunchao commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2073980462 > that this is the current state of the tests on this branch Yes that's unfortunately the current state of branch-2.3. We do know a fixed set of tests are failing though and are using that as the baseline for testing against PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
sunchao commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2073979665 Thanks @pan3793 @lirui-apache and @pvary . It looks like this PR has more tests failing than the previous PR: https://github.com/apache/hive/assets/506679/ddd8cf84-193c-4f7b-8b68-5e1248407972;> In the previous PR: #4892, there were only 27 tests failing (normally there would only be 26 tests but 1 was flaky in that PR). Could you double check whether the test failures are related? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
pan3793 commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2071642313 kindly ping @sunchao, are we good to go? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
pvary commented on code in PR #5204:
URL: https://github.com/apache/hive/pull/5204#discussion_r1574445728
##
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##
@@ -608,6 +608,33 @@ public boolean openTransaction(String isolationLevel) {
return result;
}
+ @Override
+ public long updateParameterWithExpectedValue(Table table, String key, String
expectedValue, String newValue)
+ throws MetaException, NoSuchObjectException {
+final Table _table = table;
Review Comment:
This is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
pan3793 commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2068803544 @pvary Could you please take a look at this one? AFAIK it's the last one before the next RC for 2.3.10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]
pan3793 commented on code in PR #5204:
URL: https://github.com/apache/hive/pull/5204#discussion_r1573368837
##
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##
@@ -608,6 +608,33 @@ public boolean openTransaction(String isolationLevel) {
return result;
}
+ @Override
+ public long updateParameterWithExpectedValue(Table table, String key, String
expectedValue, String newValue)
+ throws MetaException, NoSuchObjectException {
+final Table _table = table;
Review Comment:
this might be limitation of Java 7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
