[GitHub] [arrow] BryanCutler commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-27 Thread GitBox 


BryanCutler commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-634963132


   merged to master, thanks @liyafan82 !



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] BryanCutler commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-22 Thread GitBox 


BryanCutler commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-632887913


   Thanks @liyafan82 , looks like they didn't pass on this first try. Any idea 
what was causing the error:
   ```
   Error accessing files
   Current token (VALUE_STRING) not numeric, can not use numeric value accessors
at [Source: (File); line: 65, column: 14]
   12:46:37.776 [main] ERROR org.apache.arrow.tools.Integration - Error 
accessing files
   com.fasterxml.jackson.core.JsonParseException: Current token (VALUE_STRING) 
not numeric, can not use numeric value accessors
at [Source: (File); line: 65, column: 14]
at 
com.fasterxml.jackson.core.JsonParser._constructError(JsonParser.java:1804)
at 
com.fasterxml.jackson.core.base.ParserMinimalBase._reportError(ParserMinimalBase.java:698)
at 
com.fasterxml.jackson.core.base.ParserBase._parseNumericValue(ParserBase.java:781)
at 
com.fasterxml.jackson.core.base.ParserBase._parseIntValue(ParserBase.java:799)
at 
com.fasterxml.jackson.core.base.ParserBase.getIntValue(ParserBase.java:645)
at 
org.apache.arrow.vector.ipc.JsonFileReader$BufferHelper$5.read(JsonFileReader.java:306)
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] BryanCutler commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-18 Thread GitBox 


BryanCutler commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-630444330


   The `generate_primitive_large_offsets_case` looks like it is just testing 
'largebinary', 'largeutf8'. Are large lists somehow part of that?
   
   ```python
   def generate_primitive_large_offsets_case(batch_sizes):
   types = ['largebinary', 'largeutf8']
   
   fields = []
   
   for type_ in types:
   fields.append(get_field(type_ + "_nullable", type_, nullable=True))
   fields.append(get_field(type_ + "_nonnullable", type_, 
nullable=False))
   
   return _generate_file('primitive_large_offsets', fields, batch_sizes
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] BryanCutler commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-15 Thread GitBox 


BryanCutler commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-629419409


   I think you should be removing the skip Java here 
https://github.com/apache/arrow/blob/2f72713446b04f8979b04f907e7185985028b0a8/dev/archery/archery/integration/datagen.py#L1480
 to enable integration testing for this.  I'll try to take another review pass 
early next week.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org