Dandandan commented on pull request #9567: URL: https://github.com/apache/arrow/pull/9567#issuecomment-788196901
The features for cryptography functions looks good to me! Thanks @seddonm1 ! I think it is a good idea to make some things optional, to be able to exclude certain features. I think the features introduce some more complexity to the build, as we introduce more variants that maybe could fail to compile or to fail passing test in some configuration. So, overall I think we should strive to keep the usage relatively straightforward and avoid too complex usage. If we can reduce the number of dependencies or move something out, I think that might be preferable if at all possible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
