[GitHub] [arrow] alamb commented on a change in pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
alamb commented on a change in pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#discussion_r562040108
##
File path: .github/workflows/rust.yml
##
@@ -226,6 +226,40 @@ jobs:
cd rust
cargo clippy --all-targets --workspace -- -D warnings -A
clippy::redundant_field_names
+ miri-checks:
+name: Miri Checks
+runs-on: ubuntu-latest
+strategy:
+ matrix:
+arch: [amd64]
+rust: [nightly-2021-01-19]
+steps:
+ - uses: actions/checkout@v2
+with:
+ submodules: true
+ - uses: actions/cache@v2
+with:
+ path: |
+~/.cargo/registry
+~/.cargo/git
+target
+ key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
+ - name: Setup Rust toolchain
+run: |
+ rustup toolchain install ${{ matrix.rust }}
+ rustup default ${{ matrix.rust }}
+ rustup component add rustfmt clippy miri
+ - name: Run Miri Checks
+env:
+ RUST_BACKTRACE: full
+ RUST_LOG: 'trace'
+run: |
+ export MIRIFLAGS="-Zmiri-disable-isolation"
+ cd rust
+ cargo miri setup
+ cargo clean
+ cargo miri test || true
Review comment:
```suggestion
# Ignore MIRI errors until we can get a clean run
cargo miri test || true
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
alamb commented on a change in pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#discussion_r562040108
##
File path: .github/workflows/rust.yml
##
@@ -226,6 +226,40 @@ jobs:
cd rust
cargo clippy --all-targets --workspace -- -D warnings -A
clippy::redundant_field_names
+ miri-checks:
+name: Miri Checks
+runs-on: ubuntu-latest
+strategy:
+ matrix:
+arch: [amd64]
+rust: [nightly-2021-01-19]
+steps:
+ - uses: actions/checkout@v2
+with:
+ submodules: true
+ - uses: actions/cache@v2
+with:
+ path: |
+~/.cargo/registry
+~/.cargo/git
+target
+ key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
+ - name: Setup Rust toolchain
+run: |
+ rustup toolchain install ${{ matrix.rust }}
+ rustup default ${{ matrix.rust }}
+ rustup component add rustfmt clippy miri
+ - name: Run Miri Checks
+env:
+ RUST_BACKTRACE: full
+ RUST_LOG: 'trace'
+run: |
+ export MIRIFLAGS="-Zmiri-disable-isolation"
+ cd rust
+ cargo miri setup
+ cargo clean
+ cargo miri test || true
Review comment:
```suggestion
# Ignore MIRI errors until we can get a clean run
cargo miri test || true
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
