[GitHub] [arrow] alamb commented on pull request #9572: ARROW-11779: [Rust] make alloc module public

2021-03-01 Thread GitBox 


alamb commented on pull request #9572:
URL: https://github.com/apache/arrow/pull/9572#issuecomment-787871070


   > I do think that an AlignedVec in Arrow could speed up some code and make 
some internal code easier to maintain. If you want I could clean it up and 
propose a PR.
   
   @ritchie46  I would enjoy helping review that code as well as `ChunkedAray`
   
   I spent some time reviewing  
[`ChunkedArray])(https://github.com/ritchie46/polars/blob/6f2dfd43dbf7ab44cbd2904af57d3441a1b52853/polars/polars-core/src/chunked_array/mod.rs#L141-L157)
 and it looks very useful for something in IOx (the ingest path). 
   
   Thank you for the pointers (and the well commented code)  



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9572: ARROW-11779: [Rust] make alloc module public

2021-02-28 Thread GitBox 


alamb commented on pull request #9572:
URL: https://github.com/apache/arrow/pull/9572#issuecomment-787443809


   Thanks @ritchie46 -- the idea of `AlignedVec` is quite cool (something like 
that would likely be useful for us in IOx when we also want to go back / forth 
between `Vec` and arrow Arrays. 
   
   I wonder if it would make sense to consider  move `AlignedVec` and 
`ChunkedArray` into the arrow crate itself. 樂 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org