[GitHub] [arrow] jianxind commented on a change in pull request #6954: ARROW-8440: [C++] Refine SIMD header files

2020-04-22 Thread GitBox 


jianxind commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r412846457



##
File path: docs/source/developers/benchmarks.rst
##
@@ -59,7 +59,7 @@ Sometimes, it is required to pass custom CMake flags, e.g.
 .. code-block:: shell
 
   export CC=clang-8 CXX=clang++8
-  archery benchmark run --cmake-extras="-DARROW_USE_SIMD=ON"
+  archery benchmark run --cmake-extras="-DARROW_SIMD_LEVEL=NONE"

Review comment:
   Get it, then ARROW_SIMD_LEVEL=NONE is fine:) 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] jianxind commented on a change in pull request #6954: ARROW-8440: [C++] Refine SIMD header files

2020-04-22 Thread GitBox 


jianxind commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r412709153



##
File path: docs/source/developers/benchmarks.rst
##
@@ -59,7 +59,7 @@ Sometimes, it is required to pass custom CMake flags, e.g.
 .. code-block:: shell
 
   export CC=clang-8 CXX=clang++8
-  archery benchmark run --cmake-extras="-DARROW_USE_SIMD=ON"
+  archery benchmark run --cmake-extras="-DARROW_SIMD_LEVEL=NONE"

Review comment:
   I guess it should be SSE4_2 as it's the default option. ARROW_USE_SIMD 
is on as default also. Or just rm the cmake-extras?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] jianxind commented on a change in pull request #6954: ARROW-8440: [C++] Refine SIMD header files

2020-04-19 Thread GitBox 


jianxind commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r411045620



##
File path: cpp/cmake_modules/DefineOptions.cmake
##
@@ -101,7 +101,6 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL 
"${CMAKE_CURRENT_SOURCE_DIR}")
   define_option_string(ARROW_SIMD_LEVEL
"SIMD compiler optimization level"
"SSE4_2" # default to SSE4.2
-   "NONE"

Review comment:
   I personally prefer to keep the NONE(zero) level here though it may 
duplicate to ARROW_USE_SIMD. Level usually start from zero.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org