[GitHub] [arrow] jorgecarleitao commented on pull request #7879: ARROW-9618: [Rust] [DataFusion] Made it easier to write optimizers

2020-08-14 Thread GitBox 


jorgecarleitao commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-674191488


   Incorporated [this 
comment](https://github.com/apache/arrow/pull/7880#discussion_r470753855) from 
@alamb and squashed the whole thing in two commits. Thanks @alamb for pushing 
for the assert there. It makes total sense.  



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] jorgecarleitao commented on pull request #7879: ARROW-9618: [Rust] [DataFusion] Made it easier to write optimizers

2020-08-13 Thread GitBox 


jorgecarleitao commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-673882408


   @alamb , I agree with you that we will need to migrate to a visitor pattern. 
The goal of this PR is to write functions that walk and re-write the tree, so 
that we do not have to copy-paste stuff when writing an optimizer. This will 
make it easier to migrate, since there is well defined pattern in place to 
migrate from.
   
   @andygrove and @alamb , I rebased this against master again.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] jorgecarleitao commented on pull request #7879: ARROW-9618: [Rust] [DataFusion] Made it easier to write optimizers

2020-08-11 Thread GitBox 


jorgecarleitao commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-672568598


   Thanks, @andygrove . This is now rebased.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] jorgecarleitao commented on pull request #7879: ARROW-9618: [Rust] [DataFusion] Made it easier to write optimizers

2020-08-04 Thread GitBox 


jorgecarleitao commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-668615992


   Ups, forgot to change the status. Ready to review, @andygrove .



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org