[GitHub] [arrow] jorgecarleitao commented on pull request #9215: ARROW-11270: [Rust] Array slice accessors
jorgecarleitao commented on pull request #9215: URL: https://github.com/apache/arrow/pull/9215#issuecomment-767712832 @tyrelr , could you rebase against master? @kszucs , something may have happened to the force push: the commits seem funny. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #9215: ARROW-11270: [Rust] Array slice accessors
jorgecarleitao commented on pull request #9215: URL: https://github.com/apache/arrow/pull/9215#issuecomment-766158069 @tyrelr , I believe that you may have to run the benches against the latest master vs your branch rebased, for consistency: 499b6d0c is before a significant change to the mutable buffer's performance. E.g. this code does not touch `add`, but there is a 40% difference in the benches (consistent with the PR that optimizes that kernel. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #9215: ARROW-11270: [Rust] Array slice accessors
jorgecarleitao commented on pull request #9215: URL: https://github.com/apache/arrow/pull/9215#issuecomment-763555725 Ready to merge. Note that it has some backward incompatible changes, so PRs on top need to be merged carefully. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
