[GitHub] [arrow] jorisvandenbossche commented on pull request #8677: ARROW-10617: [Python] Fix RecordBatchStreamReader iteration with Python 3.8
jorisvandenbossche commented on pull request #8677: URL: https://github.com/apache/arrow/pull/8677#issuecomment-729705678 > Then could we get this one merged first ? Ideally we would first ensure we have such a build, so we can know it is failing before applying this patch (so we know that the issue would actually be caught by our tests). (now, I just mentioned on the issue that I can't reproduce the failure) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #8677: ARROW-10617: [Python] Fix RecordBatchStreamReader iteration with Python 3.8
jorisvandenbossche commented on pull request #8677: URL: https://github.com/apache/arrow/pull/8677#issuecomment-729633901 But don't we have a ursabot build with python 3.8? (they don't seem active / be triggered on this PR, though) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #8677: ARROW-10617: [Python] Fix RecordBatchStreamReader iteration with Python 3.8
jorisvandenbossche commented on pull request #8677: URL: https://github.com/apache/arrow/pull/8677#issuecomment-729632072 Indeed, it seems the full `test_ipc.py` file is being skipped on the "Python 3.8 Without Pandas" build (https://github.com/apache/arrow/pull/8677/checks?check_run_id=1406477146). And this is because we don't have a 3.8 build with pandas, see this comment at the top of the file: ``` # TODO(wesm): The IPC tests depend a lot on pandas currently, so all excluded # when it is not installed pytestmark = pytest.mark.pandas ``` (so certainly a TODO we should resolve) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
